From: Gavin Li <gavin@matician.com>
To: Mark Wielaard <mark@klomp.org>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH] libdwfl: Read no more than required to parse dynamic sections
Date: Thu, 1 Dec 2022 13:13:05 -0800 [thread overview]
Message-ID: <CACB127+_44NnDFptSrvvX8c0dmtAL+n8m8JXsCRZgAkuea5v4g@mail.gmail.com> (raw)
In-Reply-To: <Y4fj4W4nzSIw52Iw@wildebeest.org>
Awesome, thanks for looking over this. I only have one comment:
there's an extra "xlatefrom.d_size = xlatefrom.d_size;" line that
should be removed.
dwfl_elf_phdr_memory_callback is called from dwfl_link_map_report
but if any issues arise, those could be addressed in a separate patch.
Best,
Gavin
On Wed, Nov 30, 2022 at 3:14 PM Mark Wielaard <mark@klomp.org> wrote:
>
> Hi Gavin,
>
> On Tue, Nov 29, 2022 at 01:48:42PM -0800, Gavin Li wrote:
> > I think for the purposes of reading small segments (like PT_DYNAMIC
> > and PT_NOTE), we should ignore *buffer_available altogether.
>
> Thanks for walking me through the code. I think you are right and none
> of the buffer_available checks are necessary. So I removed them all. I
> also adjusted the commit message a bit. Could you look at this patch
> and let me know if this works for you?
>
> Cheers,
>
> Mark
next prev parent reply other threads:[~2022-12-01 21:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 6:26 gavin
2022-11-29 15:25 ` Mark Wielaard
2022-11-29 21:48 ` Gavin Li
2022-11-30 23:14 ` Mark Wielaard
2022-12-01 21:13 ` Gavin Li [this message]
2022-12-13 16:49 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACB127+_44NnDFptSrvvX8c0dmtAL+n8m8JXsCRZgAkuea5v4g@mail.gmail.com \
--to=gavin@matician.com \
--cc=elfutils-devel@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).