public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Andrei Homescu <ah@immunant.com>
To: Mark Wielaard <mark@klomp.org>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH] libelf: Fix unaligned d_off offsets for input sections with large alignments
Date: Thu, 8 Jul 2021 10:58:26 -0700	[thread overview]
Message-ID: <CAGynJTWBAfoRkLWrhzaVa=MAezFb2pRp3gx=v96AeuWtBNPsJQ@mail.gmail.com> (raw)
In-Reply-To: <086caea17d4700ae2d6ead8d722906002bdcb475.camel@klomp.org>

On Thu, Jul 8, 2021 at 2:37 AM Mark Wielaard <mark@klomp.org> wrote:

> Hi Andrei,
>
> On Wed, 2021-07-07 at 13:24 -0700, Andrei Homescu wrote:
> > I wrote this patch on behalf of someone else, so the copyright line
> > should be:
> > Copyright (C) 2021 Runsafe Security, Inc.
>
> OK, changed.
>
> > > The testcase already fails before the patch and succeeds after, but
> > > it would be nice to double check the output with elflint just in
> > > case. Shall we add:
> > >
> > > testrun ${abs_top_builddir}/src/elflint --gnu $outfile
> >
> > Sounds good, no objection from me.
> > Should I submit an updated version of the patch, or can you add this
> > on your end?
>
> I made those two tweaks and pushed as:
>
>
> https://sourceware.org/git/?p=elfutils.git;a=commit;h=b3601167d7a4c9f34eb65c3892c9ef25e3c1c66f
>
> Thanks,
>
> Mark
>

That's great, thank you!
Andrei

      reply	other threads:[~2021-07-08 17:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29  1:26 Andrei Homescu
2021-07-07 12:02 ` Mark Wielaard
2021-07-07 20:24   ` Andrei Homescu
2021-07-08  9:37     ` Mark Wielaard
2021-07-08 17:58       ` Andrei Homescu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGynJTWBAfoRkLWrhzaVa=MAezFb2pRp3gx=v96AeuWtBNPsJQ@mail.gmail.com' \
    --to=ah@immunant.com \
    --cc=elfutils-devel@sourceware.org \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).