public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Aaron Merey <amerey@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: elfutils-devel@sourceware.org,
	"Frederik “Freso” S. Olesen" <freso.dk@gmail.com>
Subject: Re: [PATCH] config/profile.fish.in: Prevent bracketed variables and unmatched wildcard errors
Date: Wed, 17 Apr 2024 14:46:28 -0400	[thread overview]
Message-ID: <CAJDtP-TVAYoOSx+A+K5EkX3cf+tDC0KXpBdnS9YTp_U30xT4Dw@mail.gmail.com> (raw)
In-Reply-To: <c3qywhxijvz3xvlutebohxlbee5meyouq5wvm3t4megymdhzlw@6mekqfwho7dz>

On Wed, Mar 27, 2024 at 10:06 AM Mark Wielaard <mark@klomp.org> wrote:
>
> Not knowing fish this looks OK to me.  We might want a testcase like
> the one that was just added for config/profile.sh to make sure we ship
> something that runs correctly.  Could be something as simple as:
>
> type fish 2>/dev/null || (echo "no fish installed"; exit 77)
> fish ${abs_top_builddir}/config/profile.fish

On Sat, Mar 30, 2024 at 7:32 AM Frederik “Freso” S. Olesen
<freso.dk@gmail.com> wrote:
>
> On Wed, Mar 27, 2024 at 03:06:48PM +0100, Mark Wielaard wrote:
> > Adding Freso to the CC since he is the original author of the fish
> > support.
>
> Looks good to me! I don’t want to claim any specific authorship
> or special knowledge of it. I basically just adapted the existing
> bash/.sh profile script for local use and then retrofitted that
> for upstream submission. I’m happy that other fish users are
> contributing to improving it! :)

Thanks, pushed as commit eeea53b41b12dc9633ce6a3b1eb5c7d0ba0e057f
with Mark's testcase added.

Aaron


      reply	other threads:[~2024-04-17 18:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 23:52 Aaron Merey
2024-03-27 14:06 ` Mark Wielaard
2024-03-30 11:32   ` Frederik “Freso” S. Olesen
2024-04-17 18:46     ` Aaron Merey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJDtP-TVAYoOSx+A+K5EkX3cf+tDC0KXpBdnS9YTp_U30xT4Dw@mail.gmail.com \
    --to=amerey@redhat.com \
    --cc=elfutils-devel@sourceware.org \
    --cc=freso.dk@gmail.com \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).