[PATCH] libdwfl: Don't undef _

[PATCH] libdwfl: Don't undef _

[Mark Wielaard]

A couple of files undefined _, which is defined in lib/eu-config.h as
gettext helper macro. This seems unnecessary and arbitrary.

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 libdwfl/ChangeLog                    | 7 +++++++
 libdwfl/core-file.c                  | 1 -
 libdwfl/dwfl_segment_report_module.c | 1 -
 libdwfl/elf-from-memory.c            | 1 -
 libdwfl/open.c                       | 1 -
 5 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index 1b465e48..9cd2f03c 100644
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,3 +1,10 @@
+2022-12-21  Mark Wielaard  <mark@klomp.org>
+
+	* core-file.c: Don't undef _.
+	* dwfl_segment_report_module.c: Likewise.
+	* elf-from-memory.c: Likewise.
+	* open.c: Likewise.
+
 2022-12-20  Mark Wielaard  <mark@klomp.org>
 
 	* Makefile.am (AM_CPPFLAGS): debuginfod.h is in builddir.
diff --git a/libdwfl/core-file.c b/libdwfl/core-file.c
index 1ddf0f18..87c940cb 100644
--- a/libdwfl/core-file.c
+++ b/libdwfl/core-file.c
@@ -29,7 +29,6 @@
 
 #include <config.h>
 #include "libelfP.h"	/* For NOTE_ALIGN.  */
-#undef	_
 #include "libdwflP.h"
 #include <gelf.h>
 
diff --git a/libdwfl/dwfl_segment_report_module.c b/libdwfl/dwfl_segment_report_module.c
index 41285103..3ef62a7d 100644
--- a/libdwfl/dwfl_segment_report_module.c
+++ b/libdwfl/dwfl_segment_report_module.c
@@ -29,7 +29,6 @@
 
 #include <config.h>
 #include "libelfP.h"	/* For NOTE_ALIGN4 and NOTE_ALIGN8.  */
-#undef	_
 #include "libdwflP.h"
 #include "common.h"
 
diff --git a/libdwfl/elf-from-memory.c b/libdwfl/elf-from-memory.c
index f7fb3ab7..e9b330fd 100644
--- a/libdwfl/elf-from-memory.c
+++ b/libdwfl/elf-from-memory.c
@@ -28,7 +28,6 @@
 
 #include <config.h>
 #include "libelfP.h"
-#undef _
 
 #include "libdwflP.h"
 
diff --git a/libdwfl/open.c b/libdwfl/open.c
index 32bd7ff8..fcb7f8ea 100644
--- a/libdwfl/open.c
+++ b/libdwfl/open.c
@@ -32,7 +32,6 @@
 #endif
 
 #include "libelfP.h"
-#undef	_
 #include "libdwflP.h"
 
 #if !USE_BZLIB
-- 
2.30.2

Re: [PATCH] libdwfl: Don't undef _

[Mark Wielaard]

On Wed, Dec 21, 2022 at 04:43:05PM +0100, Mark Wielaard wrote:
> A couple of files undefined _, which is defined in lib/eu-config.h as
> gettext helper macro. This seems unnecessary and arbitrary.

Pushed.