From: Mark Wielaard <mark@klomp.org>
To: Noah Sanci <nsanci@redhat.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: debuginfod: Query debuginfod servers before printing response
Date: Fri, 17 Sep 2021 19:49:00 +0200 [thread overview]
Message-ID: <YUTVDHzkXv+Z22C/@wildebeest.org> (raw)
In-Reply-To: <CAJXA7qi8Le-w4ZXkLfEfHW7xud3Ped3D9iwJ5FVfQFDw4=pKGw@mail.gmail.com>
Hi Noah,
On Fri, Sep 17, 2021 at 01:38:50PM -0400, Noah Sanci via Elfutils-devel wrote:
> Here is an updated patch, removing checks for http response headers
> which debuginfod is not guaranteed
> to respond with. These headers caused tests to fail despite receiving
> sufficient headers to confirm functionality.
Yes, this looks good. Just checking for Content-Length and the new
X-DEBUGINFOD- headers should be good enough.
Nice commit message. Please push.
Thanks,
Mark
prev parent reply other threads:[~2021-09-17 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 14:55 Noah Sanci
2021-09-17 15:06 ` Mark Wielaard
2021-09-17 17:38 ` Noah Sanci
2021-09-17 17:49 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUTVDHzkXv+Z22C/@wildebeest.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=nsanci@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).