Re: Buildbot failure in Wildebeest Builder on whole buildset

[Mark Wielaard <mark@klomp.org>]

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

Hi,

On Sat, 2020-10-31 at 02:12 +0000, buildbot@builder.wildebeest.org
wrote:
> The Buildbot has detected a failed build on builder whole buildset
> while building elfutils.
> Full details are available at:
>     https://builder.wildebeest.org/buildbot/#builders/2/builds/600
> 
> Buildbot URL: https://builder.wildebeest.org/buildbot/
> 
> Worker for this Build: debian-amd64
> 
> Build Reason: <unknown>
> Blamelist: Mark Wielaard <mark@klomp.org>
> 
> BUILD FAILED: failed test (failure)
> [...]
> Worker for this Build: debian-i386
> [...]
> Worker for this Build: debian-arm64

Debian, debian, debian.
Debian uses dash as /bin/sh which is pretty strict about syntax. It
didn't like the== in  the test for strings in the test-wrapper.sh.

Fixed as attached.

Cheers,

Mark

[-- Attachment #2: 0001-tests-Remove-bashism-from-test-wrapper.sh-bin-sh-scr.patch --]
[-- Type: text/x-patch, Size: 1349 bytes --]

From 92692b817028499111a5446cf1bc8369d0a3b408 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Sat, 31 Oct 2020 11:19:23 +0100
Subject: [PATCH] tests: Remove bashism from test-wrapper.sh /bin/sh script.

Debian uses dash as /bin/sh which is pretty strict about syntax. It
didn't like the == in  the test for strings in the test-wrapper.sh.
Replace by single =.

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 tests/ChangeLog       | 4 ++++
 tests/test-wrapper.sh | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/ChangeLog b/tests/ChangeLog
index b84f2af0..17c6ba2d 100644
--- a/tests/ChangeLog
+++ b/tests/ChangeLog
@@ -1,3 +1,7 @@
+2020-10-31  Mark Wielaard  <mark@klomp.org>
+
+	* test-wrapper.sh: Use =, not == for string compare.
+
 2020-10-29  Mark Wielaard  <mark@klomp.org>
 
 	* test-wrapper.sh: Determine whether the test is a script or not
diff --git a/tests/test-wrapper.sh b/tests/test-wrapper.sh
index db16c591..c5d3f159 100755
--- a/tests/test-wrapper.sh
+++ b/tests/test-wrapper.sh
@@ -66,7 +66,7 @@ fi
 
 # When it is a run-*.sh script the VALGRIND_CMD will be passed on
 # otherwise we'll need to run the binary explicitly under valgrind.
-if [ "x$is_shell_script" == "xyes" ]; then
+if [ "x$is_shell_script" = xyes ]; then
   exec "$@"
 else
   exec $VALGRIND_CMD "$@"
-- 
2.18.4