Re: Buildbot failure in Wildebeest Builder on whole buildset

[Mark Wielaard <mark@klomp.org>]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

On Thu, 2019-08-29 at 13:59 +0000, buildbot@builder.wildebeest.org
wrote:
> The Buildbot has detected a failed build on builder whole buildset
> while building elfutils.
> Full details are available at:
>     https://builder.wildebeest.org/buildbot/#builders/16/builds/182

Well that is unfortunate. The make check (under valgrind) just timed
out. That arm64 machine is really slow. And looking at some of the
other builders I see make check under valgrind (or make distcheck,
which enables the gcc undefined sanitizer and valgrind) became a lot
slower (non-valgrind builds/checks don't seem to be impacted).

It looks like the cause is our self checks. The majority of files we
use for that seem to be exactly those files that became a lot bigger.
Which means the tests use a lot more memory and increases the runtime
(which gets 10x longer under valgrind).

I am replacing some of the self test files with smaller
executables/libraries as attached. Hopefully that will reduce the make
check runtime under valgrind so builder don't time out.

Cheers,

Mark

[-- Attachment #2: 0001-tests-Use-smaller-self-test-files.patch --]
[-- Type: text/x-patch, Size: 1586 bytes --]

From bb106065dc6962fabf1c163f18c932650dac6580 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Thu, 29 Aug 2019 16:21:35 +0200
Subject: [PATCH] tests: Use smaller self test files.

Don't use the largest executables/libraries to reduce the make check time.

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 tests/ChangeLog    | 6 ++++++
 tests/test-subr.sh | 8 ++++----
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/tests/ChangeLog b/tests/ChangeLog
index 657e73b2..69e43ca8 100644
--- a/tests/ChangeLog
+++ b/tests/ChangeLog
@@ -1,3 +1,9 @@
+2019-08-29  Mark Wielaard  <mark@klomp.org>
+
+	* test-subr.sh (self_test_files_exe): replace elfcmp, objdump and
+	readelf with elfclassify, stack and unstrip.
+	(self_test_files_lib): Replace libdw.so with libasm.so.
+
 2019-07-05  Omar Sandoval  <osandov@fb.com>
 
 	* Makefile.am: Remove -ldl.
diff --git a/tests/test-subr.sh b/tests/test-subr.sh
index e23a0176..e768c1e5 100644
--- a/tests/test-subr.sh
+++ b/tests/test-subr.sh
@@ -116,12 +116,12 @@ program_transform()
 }
 
 self_test_files_exe=`echo ${abs_top_builddir}/src/addr2line \
-${abs_top_builddir}/src/elfcmp \
-${abs_top_builddir}/src/objdump \
-${abs_top_builddir}/src/readelf`
+${abs_top_builddir}/src/elfclassify \
+${abs_top_builddir}/src/stack \
+${abs_top_builddir}/src/unstrip`
 
 self_test_files_lib=`echo ${abs_top_builddir}/libelf/libelf.so \
-${abs_top_builddir}/libdw/libdw.so`
+${abs_top_builddir}/libasm/libasm.so`
 
 self_test_files_obj=`echo ${abs_top_builddir}/src/size.o \
 ${abs_top_builddir}/src/strip.o`
-- 
2.18.1