From: Mark Wielaard <mark@klomp.org>
To: Di Chen <dichen@redhat.com>, "Frank Ch. Eigler" <fche@redhat.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH] debuginfod: PR27917 - protect against federation loops
Date: Fri, 27 Aug 2021 19:42:21 +0200 [thread overview]
Message-ID: <a53f364d9208983172de9fa8ed2dd5d79a751652.camel@klomp.org> (raw)
In-Reply-To: <CAN-Pu7QyQ0ML04_OZtt-KXva+vU4mCd_b3CONtK4FGtvKZmR_A@mail.gmail.com>
Hi dichen,
On Fri, 2021-08-20 at 20:44 +0800, Di Chen via Elfutils-devel wrote:
> 1) moved the XFF check to handle_buildid.
> 2) replace "livelock" with "deadlock" in the commit message.
This looks very good, thanks not just for the code but for also
including documentation and a testcase.
I did make one small change to the test:
diff --git a/tests/run-debuginfod-find.sh b/tests/run-debuginfod-find.sh
index dbf20975..7e12dd7f 100755
--- a/tests/run-debuginfod-find.sh
+++ b/tests/run-debuginfod-find.sh
@@ -819,6 +819,11 @@ while true; do
ss -atn | fgrep -e ":$PORT4" -e ":$PORT5"|| break
done
+# Make sure the vlogs are cleaned up after the test
+# and that they are printed on error.
+tempfiles vlog$PORT4 vlog$PORT5
+errfiles vlog$PORT4 vlog$PORT5
+
env LD_LIBRARY_PATH=$ldpath DEBUGINFOD_URLS=http://127.0.0.1:$PORT5 ${abs_builddir}/../debuginfod/debuginfod $VERBOSE --forwarded-ttl-limit 0 -p $PORT4 > vlog$PORT4 2>&1 &
PID5=$!
And added ChangeLog file entries. Then pushed.
Thanks,
Mark
prev parent reply other threads:[~2021-08-27 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 14:35 Di Chen
2021-08-18 22:55 ` Frank Ch. Eigler
2021-08-20 12:44 ` Di Chen
2021-08-27 17:42 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a53f364d9208983172de9fa8ed2dd5d79a751652.camel@klomp.org \
--to=mark@klomp.org \
--cc=dichen@redhat.com \
--cc=elfutils-devel@sourceware.org \
--cc=fche@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).