* [Bug libdw/27405] New: libdw_get_srcfiles should not imply srclines
@ 2021-02-12 16:18 fche at redhat dot com
2021-02-12 16:24 ` [Bug libdw/27405] " mark at klomp dot org
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: fche at redhat dot com @ 2021-02-12 16:18 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27405
Bug ID: 27405
Summary: libdw_get_srcfiles should not imply srclines
Product: elfutils
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: libdw
Assignee: unassigned at sourceware dot org
Reporter: fche at redhat dot com
CC: elfutils-devel at sourceware dot org
Target Milestone: ---
In debuginfod, we use _get_srcfiles to fetch file names only. We do not care
about srclines, so libdw's effort in allocating all that memory, and filling it
in, is just a waste. Let's make srcfiles great by skipping the per-line data.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug libdw/27405] libdw_get_srcfiles should not imply srclines
2021-02-12 16:18 [Bug libdw/27405] New: libdw_get_srcfiles should not imply srclines fche at redhat dot com
@ 2021-02-12 16:24 ` mark at klomp dot org
2024-03-29 1:14 ` amerey at redhat dot com
2024-04-11 16:40 ` amerey at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: mark at klomp dot org @ 2021-02-12 16:24 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27405
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mark at klomp dot org
--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
Note that the issue is here in libdw/dwarf_getsrcfiles.c:
/* Let the more generic function do the work. It'll create more
data but that will be needed in an real program anyway. */
res = INTUSE(dwarf_getsrclines) (cudie, &lines, &nlines);
debuginfod shows that comment is wrong.
There is also the internal __libdw_getsrclines function which is used in a
couple of place to "only" get the srcfiles.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug libdw/27405] libdw_get_srcfiles should not imply srclines
2021-02-12 16:18 [Bug libdw/27405] New: libdw_get_srcfiles should not imply srclines fche at redhat dot com
2021-02-12 16:24 ` [Bug libdw/27405] " mark at klomp dot org
@ 2024-03-29 1:14 ` amerey at redhat dot com
2024-04-11 16:40 ` amerey at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: amerey at redhat dot com @ 2024-03-29 1:14 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27405
Aaron Merey <amerey at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |amerey at redhat dot com
--- Comment #2 from Aaron Merey <amerey at redhat dot com> ---
Proposed patch:
https://sourceware.org/pipermail/elfutils-devel/2024q1/006973.html
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug libdw/27405] libdw_get_srcfiles should not imply srclines
2021-02-12 16:18 [Bug libdw/27405] New: libdw_get_srcfiles should not imply srclines fche at redhat dot com
2021-02-12 16:24 ` [Bug libdw/27405] " mark at klomp dot org
2024-03-29 1:14 ` amerey at redhat dot com
@ 2024-04-11 16:40 ` amerey at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: amerey at redhat dot com @ 2024-04-11 16:40 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27405
Aaron Merey <amerey at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #3 from Aaron Merey <amerey at redhat dot com> ---
Fixed in the following commit:
commit d4b0848be5f575ff9464fee12ce7be416e4fb392
Author: Aaron Merey <amerey@redhat.com>
Date: Mon Mar 25 15:57:25 2024 -0400
libdw: dwarf_getsrcfiles should not imply dwarf_getsrclines
dwarf_getsrcfiles causes line data to be read in addition to file data.
This is wasteful for programs which only need file or directory names.
Debuginfod server is one such example.
Fix this by moving the srcfile reading in read_srclines into a separate
function read_srcfiles. This change improves debuginfod server's max
resident set size by up to 75% during rpm indexing.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-11 16:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-12 16:18 [Bug libdw/27405] New: libdw_get_srcfiles should not imply srclines fche at redhat dot com
2021-02-12 16:24 ` [Bug libdw/27405] " mark at klomp dot org
2024-03-29 1:14 ` amerey at redhat dot com
2024-04-11 16:40 ` amerey at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).