* [Bug general/27450] New: Update Polish translation
@ 2021-02-21 13:48 piotrdrag at gmail dot com
2021-02-21 13:49 ` [Bug general/27450] " piotrdrag at gmail dot com
` (13 more replies)
0 siblings, 14 replies; 15+ messages in thread
From: piotrdrag at gmail dot com @ 2021-02-21 13:48 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
Bug ID: 27450
Summary: Update Polish translation
Product: elfutils
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: general
Assignee: unassigned at sourceware dot org
Reporter: piotrdrag at gmail dot com
CC: elfutils-devel at sourceware dot org
Target Milestone: ---
Hi,
Attached is a patch updating the Polish translation for elfutils.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug general/27450] Update Polish translation
2021-02-21 13:48 [Bug general/27450] New: Update Polish translation piotrdrag at gmail dot com
@ 2021-02-21 13:49 ` piotrdrag at gmail dot com
2021-02-21 13:57 ` piotrdrag at gmail dot com
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: piotrdrag at gmail dot com @ 2021-02-21 13:49 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
Piotr Drąg <piotrdrag at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |piotrdrag at gmail dot com
--- Comment #1 from Piotr Drąg <piotrdrag at gmail dot com> ---
Created attachment 13237
--> https://sourceware.org/bugzilla/attachment.cgi?id=13237&action=edit
Updated Polish translation
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug general/27450] Update Polish translation
2021-02-21 13:48 [Bug general/27450] New: Update Polish translation piotrdrag at gmail dot com
2021-02-21 13:49 ` [Bug general/27450] " piotrdrag at gmail dot com
@ 2021-02-21 13:57 ` piotrdrag at gmail dot com
2021-02-21 14:35 ` piotrdrag at gmail dot com
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: piotrdrag at gmail dot com @ 2021-02-21 13:57 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
Piotr Drąg <piotrdrag at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #13237|0 |1
is obsolete| |
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug general/27450] Update Polish translation
2021-02-21 13:48 [Bug general/27450] New: Update Polish translation piotrdrag at gmail dot com
2021-02-21 13:49 ` [Bug general/27450] " piotrdrag at gmail dot com
2021-02-21 13:57 ` piotrdrag at gmail dot com
@ 2021-02-21 14:35 ` piotrdrag at gmail dot com
2021-02-21 14:35 ` piotrdrag at gmail dot com
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: piotrdrag at gmail dot com @ 2021-02-21 14:35 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
--- Comment #2 from Piotr Drąg <piotrdrag at gmail dot com> ---
Created attachment 13238
--> https://sourceware.org/bugzilla/attachment.cgi?id=13238&action=edit
Update POTFILES.in
Turns out, there are some files missing from POTFILES.in.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug general/27450] Update Polish translation
2021-02-21 13:48 [Bug general/27450] New: Update Polish translation piotrdrag at gmail dot com
` (2 preceding siblings ...)
2021-02-21 14:35 ` piotrdrag at gmail dot com
@ 2021-02-21 14:35 ` piotrdrag at gmail dot com
2021-02-21 21:01 ` ldv at sourceware dot org
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: piotrdrag at gmail dot com @ 2021-02-21 14:35 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
--- Comment #3 from Piotr Drąg <piotrdrag at gmail dot com> ---
Created attachment 13239
--> https://sourceware.org/bugzilla/attachment.cgi?id=13239&action=edit
Update Polish translation
Complete update of the translation.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug general/27450] Update Polish translation
2021-02-21 13:48 [Bug general/27450] New: Update Polish translation piotrdrag at gmail dot com
` (3 preceding siblings ...)
2021-02-21 14:35 ` piotrdrag at gmail dot com
@ 2021-02-21 21:01 ` ldv at sourceware dot org
2021-02-22 15:27 ` piotrdrag at gmail dot com
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ldv at sourceware dot org @ 2021-02-21 21:01 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
Dmitry V. Levin <ldv at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
CC| |ldv at sourceware dot org
Last reconfirmed| |2021-02-21
--- Comment #4 from Dmitry V. Levin <ldv at sourceware dot org> ---
(In reply to Piotr Drąg from comment #2)
> Created attachment 13238 [details]
> Update POTFILES.in
>
> Turns out, there are some files missing from POTFILES.in.
Apparently, libcpu/i386_lex.l also contains translatable strings.
Could you add it to POTFILES.in, please?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug general/27450] Update Polish translation
2021-02-21 13:48 [Bug general/27450] New: Update Polish translation piotrdrag at gmail dot com
` (4 preceding siblings ...)
2021-02-21 21:01 ` ldv at sourceware dot org
@ 2021-02-22 15:27 ` piotrdrag at gmail dot com
2021-02-22 15:28 ` piotrdrag at gmail dot com
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: piotrdrag at gmail dot com @ 2021-02-22 15:27 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
Piotr Drąg <piotrdrag at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #13238|0 |1
is obsolete| |
--- Comment #5 from Piotr Drąg <piotrdrag at gmail dot com> ---
Created attachment 13249
--> https://sourceware.org/bugzilla/attachment.cgi?id=13249&action=edit
Update POTFILES.in
Sure thing!
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug general/27450] Update Polish translation
2021-02-21 13:48 [Bug general/27450] New: Update Polish translation piotrdrag at gmail dot com
` (5 preceding siblings ...)
2021-02-22 15:27 ` piotrdrag at gmail dot com
@ 2021-02-22 15:28 ` piotrdrag at gmail dot com
2021-03-06 2:30 ` mark at klomp dot org
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: piotrdrag at gmail dot com @ 2021-02-22 15:28 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
Piotr Drąg <piotrdrag at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #13239|0 |1
is obsolete| |
--- Comment #6 from Piotr Drąg <piotrdrag at gmail dot com> ---
Created attachment 13250
--> https://sourceware.org/bugzilla/attachment.cgi?id=13250&action=edit
Update Polish translation
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug general/27450] Update Polish translation
2021-02-21 13:48 [Bug general/27450] New: Update Polish translation piotrdrag at gmail dot com
` (6 preceding siblings ...)
2021-02-22 15:28 ` piotrdrag at gmail dot com
@ 2021-03-06 2:30 ` mark at klomp dot org
2021-03-06 3:00 ` ldv at sourceware dot org
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: mark at klomp dot org @ 2021-03-06 2:30 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mark at klomp dot org
--- Comment #7 from Mark Wielaard <mark at klomp dot org> ---
Two questions:
1) How should we manage the POTFILES? How did you note the missing files? Can
this be automated somehow?
2) Is it OK to add a Signed-off-by: Piotr Drąg <piotrdrag@gmail.com> to the
commit? See the following text from the CONTRIBUTING file for context:
Sign your work
To facilitate tracking of who did what, we've adopted a "sign-off"
procedure for patches based on the procedure used by the Linux kernel
project.
The sign-off is a simple line at the end of the explanation for the
patch, which certifies that you wrote it or otherwise have the right
to pass it on as a patch under an appropriate license. The rules are
pretty simple: if you can certify the below:
Developer's Certificate of Origin
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me,
and I have the right to submit the contribution under each
license indicated in, or otherwise designated as being
applicable to, the file.
(b) The contribution was provided directly to me by some other
person who certified (a), and I have not modified it.
(c) I understand and agree that the project and the
contribution are public and that a record of the
contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely
and may be redistributed.
then you just add a line saying
Signed-off-by: Random J Developer <random@developer.example.org>
using your real name (sorry, no pseudonyms or anonymous contributions.)
git commit --signoff will add such a Signed-off-by line at the end of
the commit log message for you.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug general/27450] Update Polish translation
2021-02-21 13:48 [Bug general/27450] New: Update Polish translation piotrdrag at gmail dot com
` (7 preceding siblings ...)
2021-03-06 2:30 ` mark at klomp dot org
@ 2021-03-06 3:00 ` ldv at sourceware dot org
2021-03-06 10:34 ` piotrdrag at gmail dot com
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ldv at sourceware dot org @ 2021-03-06 3:00 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
--- Comment #8 from Dmitry V. Levin <ldv at sourceware dot org> ---
(In reply to Mark Wielaard from comment #7)
> Two questions:
>
> 1) How should we manage the POTFILES? How did you note the missing files?
> Can this be automated somehow?
I was using
$ git grep -El '\<(_|[ns]gettext) *\("'
On the current master, it says the following files should be added:
$ grep '^[^#]' po/POTFILES.in |sort -u | \
comm -13 - <(git grep -El '\<(_|[ns]gettext) *\("')
libcpu/i386_lex.l
libcpu/i386_parse.y
It also says the following listed files don't contain translations:
$ grep '^[^#]' po/POTFILES.in |sort -u | \
comm -23 - <(git grep -El '\<(_|[ns]gettext) *\("')
libdw/dwarf_error.c
libdwfl/libdwflP.h
libelf/elf_error.c
src/elfcompress.c
src/stack.c
tests/backtrace.c
tests/dwflmodtest.c
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug general/27450] Update Polish translation
2021-02-21 13:48 [Bug general/27450] New: Update Polish translation piotrdrag at gmail dot com
` (8 preceding siblings ...)
2021-03-06 3:00 ` ldv at sourceware dot org
@ 2021-03-06 10:34 ` piotrdrag at gmail dot com
2021-03-06 10:53 ` ldv at sourceware dot org
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: piotrdrag at gmail dot com @ 2021-03-06 10:34 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
--- Comment #9 from Piotr Drąg <piotrdrag at gmail dot com> ---
I already included Signed-off-by in the patches. As for POTFILES, I use
intltool-update -m to detect missing files.
(In reply to Dmitry V. Levin from comment #8)
> It also says the following listed files don't contain translations:
> $ grep '^[^#]' po/POTFILES.in |sort -u | \
> comm -23 - <(git grep -El '\<(_|[ns]gettext) *\("')
> libdw/dwarf_error.c
> libdwfl/libdwflP.h
> libelf/elf_error.c
> src/elfcompress.c
> src/stack.c
> tests/backtrace.c
> tests/dwflmodtest.c
That’s not true, I guess your command ignores strings marked with N_?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug general/27450] Update Polish translation
2021-02-21 13:48 [Bug general/27450] New: Update Polish translation piotrdrag at gmail dot com
` (9 preceding siblings ...)
2021-03-06 10:34 ` piotrdrag at gmail dot com
@ 2021-03-06 10:53 ` ldv at sourceware dot org
2021-03-06 13:48 ` mark at klomp dot org
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ldv at sourceware dot org @ 2021-03-06 10:53 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
--- Comment #10 from Dmitry V. Levin <ldv at sourceware dot org> ---
(In reply to Piotr Drąg from comment #9)
> I already included Signed-off-by in the patches. As for POTFILES, I use
> intltool-update -m to detect missing files.
>
> (In reply to Dmitry V. Levin from comment #8)
> > It also says the following listed files don't contain translations:
> > $ grep '^[^#]' po/POTFILES.in |sort -u | \
> > comm -23 - <(git grep -El '\<(_|[ns]gettext) *\("')
> > libdw/dwarf_error.c
> > libdwfl/libdwflP.h
> > libelf/elf_error.c
> > src/elfcompress.c
> > src/stack.c
> > tests/backtrace.c
> > tests/dwflmodtest.c
>
> That’s not true, I guess your command ignores strings marked with N_?
Indeed. Next time I'll use git grep -El '\<(N?_|[ns]gettext) *\("' instead.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug general/27450] Update Polish translation
2021-02-21 13:48 [Bug general/27450] New: Update Polish translation piotrdrag at gmail dot com
` (10 preceding siblings ...)
2021-03-06 10:53 ` ldv at sourceware dot org
@ 2021-03-06 13:48 ` mark at klomp dot org
2021-03-06 13:49 ` mark at klomp dot org
2021-03-07 11:30 ` piotrdrag at gmail dot com
13 siblings, 0 replies; 15+ messages in thread
From: mark at klomp dot org @ 2021-03-06 13:48 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #11 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Piotr Drąg from comment #9)
> I already included Signed-off-by in the patches.
Sorry, indeed. My mistake. If you click on the diff link in bugzilla, you only
get the diff, not the commit message.
I added a ChangeLog entry to both and pushed them. Thanks.
commit 619aae135aeccf81c5b59508823d379546e1d3b7
Author: Piotr Drąg <piotrdrag@gmail.com>
Date: Sun Feb 21 15:33:43 2021 +0100
Update Polish translation
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
Signed-off-by: Piotr Drąg <piotrdrag@gmail.com>
commit b7abde7958037014531b1d331f7ba023ab47c2a0
Author: Piotr Drąg <piotrdrag@gmail.com>
Date: Sun Feb 21 14:54:46 2021 +0100
Update POTFILES.in
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
Signed-off-by: Piotr Drąg <piotrdrag@gmail.com>
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug general/27450] Update Polish translation
2021-02-21 13:48 [Bug general/27450] New: Update Polish translation piotrdrag at gmail dot com
` (11 preceding siblings ...)
2021-03-06 13:48 ` mark at klomp dot org
@ 2021-03-06 13:49 ` mark at klomp dot org
2021-03-07 11:30 ` piotrdrag at gmail dot com
13 siblings, 0 replies; 15+ messages in thread
From: mark at klomp dot org @ 2021-03-06 13:49 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
--- Comment #12 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Dmitry V. Levin from comment #10)
> (In reply to Piotr Drąg from comment #9)
> > As for POTFILES, I use
> > intltool-update -m to detect missing files.
> > [...]
> Indeed. Next time I'll use git grep -El '\<(N?_|[ns]gettext) *\("' instead.
Could/should we use one of these techniques when doing make check (in
--enable-maintainer-mode) to catch missing files?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug general/27450] Update Polish translation
2021-02-21 13:48 [Bug general/27450] New: Update Polish translation piotrdrag at gmail dot com
` (12 preceding siblings ...)
2021-03-06 13:49 ` mark at klomp dot org
@ 2021-03-07 11:30 ` piotrdrag at gmail dot com
13 siblings, 0 replies; 15+ messages in thread
From: piotrdrag at gmail dot com @ 2021-03-07 11:30 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
--- Comment #13 from Piotr Drąg <piotrdrag at gmail dot com> ---
(In reply to Mark Wielaard from comment #11)
> I added a ChangeLog entry to both and pushed them. Thanks.
Thank you!
(In reply to Mark Wielaard from comment #12)
> Could/should we use one of these techniques when doing make check (in
> --enable-maintainer-mode) to catch missing files?
You could use intltool if you’re OK with a brittle, unmaintained Perl script in
your release process.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2021-03-07 11:30 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-21 13:48 [Bug general/27450] New: Update Polish translation piotrdrag at gmail dot com
2021-02-21 13:49 ` [Bug general/27450] " piotrdrag at gmail dot com
2021-02-21 13:57 ` piotrdrag at gmail dot com
2021-02-21 14:35 ` piotrdrag at gmail dot com
2021-02-21 14:35 ` piotrdrag at gmail dot com
2021-02-21 21:01 ` ldv at sourceware dot org
2021-02-22 15:27 ` piotrdrag at gmail dot com
2021-02-22 15:28 ` piotrdrag at gmail dot com
2021-03-06 2:30 ` mark at klomp dot org
2021-03-06 3:00 ` ldv at sourceware dot org
2021-03-06 10:34 ` piotrdrag at gmail dot com
2021-03-06 10:53 ` ldv at sourceware dot org
2021-03-06 13:48 ` mark at klomp dot org
2021-03-06 13:49 ` mark at klomp dot org
2021-03-07 11:30 ` piotrdrag at gmail dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).