[Bug debuginfod/27711] New: grooming should process -I/-X

[Bug debuginfod/27711] New: grooming should process -I/-X

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27711

            Bug ID: 27711
           Summary: grooming should process -I/-X
           Product: elfutils
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: debuginfod
          Assignee: unassigned at sourceware dot org
          Reporter: fche at redhat dot com
                CC: elfutils-devel at sourceware dot org
  Target Milestone: ---

The debuginfod -I/-X regexes operate during traversal to identify those files
in need of scanning.  The regexes are not used during grooming.  This means
that if from run to run, the regex changes so that formerly indexed files are
excluded from traversal, the data is still retained in the index.

This is both good and bad.  On one hand, if the underlying data is still
available, grooming will preserve the data, and let clients ask for it.  On the
other hand, if the growing index size is a problem, and one wishes to age
no-longer-regex-matching index data out, there is no way.

Let's add a debuginfod flag to use regexes during grooming.  Specifically, in
groom(), where the stat() test exists, also check for regex matching as in
scan_source_paths().  Treat failure of the regex the same way as though the
file didn't exist.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/27711] grooming should process -I/-X

[nsanci at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27711

Noah <nsanci at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |nsanci at redhat dot com
                 CC|                            |nsanci at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/27711] grooming should process -I/-X

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27711

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |mark at klomp dot org
         Resolution|---                         |FIXED

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
commit 0ae9b791b47cdee92ac7221e3eead79c83a64a40
Author: Noah <nsanci@redhat.com>
Date:   Wed Jul 7 14:40:10 2021 -0400

    debuginfod: PR27711 - Use -I/-X regexes during groom phase

    The debuginfod -I/-X regexes operate during traversal to identify
    those files in need of scanning.  The regexes are not used during
    grooming.  This means that if from run to run, the regex changes so
    that formerly indexed files are excluded from traversal, the data is
    still retained in the index.

    This is both good and bad.  On one hand, if the underlying data is
    still available, grooming will preserve the data, and let clients ask
    for it.  On the other hand, if the growing index size is a problem,
    and one wishes to age no-longer-regex-matching index data out, there
    is no way.

    Let's add a debuginfod flag to use regexes during grooming.
    Specifically, in groom(), where the stat() test exists, also check
    for regex matching as in scan_source_paths().  Treat failure of the
    regex the same way as though the file didn't exist.

    Signed-off-by: Noah Sanci <nsanci@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.