public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug backends/27925] riscv backend only provides return value locations for code compiled for LP64D ABI
Date: Wed, 29 Sep 2021 22:14:18 +0000	[thread overview]
Message-ID: <bug-27925-10460-A8Xi7SSqyv@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27925-10460@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=27925

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #13 from Mark Wielaard <mark at klomp dot org> ---
(In reply to William Cohen from comment #12)
> The patch for the retval handling has been submitted.

Thanks. I added a ChangeLog entry, made some (GNU) code style changes and
committed as:

commit 2e57301be1bbb9c34f8a59122ab500de46eb7acb (HEAD -> master)
Author: William Cohen <wcohen@redhat.com>
Date:   Wed Sep 29 14:56:15 2021 -0400

    RISC-V: PR27925 Add support for LP64 and LP64F ABIs return values

    The RISC-V Linux kernel is compiled without floating point (the LP64
    ABI) and elfutils could not obtain return value locations for
    functions in the kernel.  This issue was noticed when Systemtap
    generated RISC-V kernel modules for scripts that used $return target
    variables in function return probes. This patch adds the needed
    support to provide return value information for the LP64 and LP64F
    ABIs.

    Signed-off-by: William Cohen <wcohen@redhat.com>

>  As mentioned in
> comment #9 testing is not trivial.  Normal user-space executables are
> compiled with floating-point enabled and those executables work fine without
> the fixes.  The LP64 and LP64F ABIs don't have the need start or libraries
> to compile user-space tests.  Leaving the testsuite for later consideration.

OK. But even a testcase for the already working "normal" user-space would be
appreciated. And we might be able to create a kernel module as testcase.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2021-09-29 22:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 18:58 [Bug backends/27925] New: " wcohen at redhat dot com
2021-09-18 21:18 ` [Bug backends/27925] " wcohen at redhat dot com
2021-09-19 10:30 ` mark at klomp dot org
2021-09-19 16:45 ` wilson at gcc dot gnu.org
2021-09-19 23:22 ` wcohen at redhat dot com
2021-09-20  2:29 ` wilson at gcc dot gnu.org
2021-09-20  7:42 ` mark at klomp dot org
2021-09-23  3:26 ` wcohen at redhat dot com
2021-09-23 14:22 ` wilson at gcc dot gnu.org
2021-09-23 14:30 ` wilson at gcc dot gnu.org
2021-09-29 13:43 ` mark at klomp dot org
2021-09-29 17:02 ` wilson at gcc dot gnu.org
2021-09-29 20:13 ` wcohen at redhat dot com
2021-09-29 22:14 ` mark at klomp dot org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27925-10460-A8Xi7SSqyv@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=elfutils-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).