From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug debuginfod/28034] debuginfod server: preserve + etc. elements in incoming webapi url
Date: Wed, 25 Aug 2021 12:33:11 +0000 [thread overview]
Message-ID: <bug-28034-10460-RzDh30200B@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28034-10460@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=28034
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #4 from Mark Wielaard <mark at klomp dot org> ---
commit 9ab0c139eebf4ba40ac721224a673e4b66d29cd9
Author: Noah Sanci <nsanci@redhat.com>
Date: Fri Jul 16 15:16:20 2021 -0400
debuginfod: PR28034 - client-side %-escape url characters
When requesting some source files, some URL-inconvenient chars
sometimes pop up. Example from f33 libstdc++:
/buildid/44d8485cb75512c2ca5c8f70afbd475cae30af4f/source/usr/src/debug/
gcc-10.3.1-1.fc33.x86_64/obj-x86_64-redhat-linux/x86_64-redhat-linux/
libstdc++-v3/src/c++11/../../../../../libstdc++-v3/src/c++11/
condition_variable.cc
As this URL is passed into debuginfod's handler_cb, it appears that the
+ signs are helpfully unescaped to spaces by libmicrohttpd, which
'course breaks everything.
In order to ensure the server properly parses urls such as this one,
%-escape characters on the client side so that the correct url
is preserved and properly processed on the server side.
https://sourceware.org/bugzilla/show_bug.cgi?id=28034
Signed-off-by: Noah Sanci <nsanci@redhat.com>
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2021-08-25 12:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 18:37 [Bug debuginfod/28034] New: " fche at redhat dot com
2021-06-30 20:00 ` [Bug debuginfod/28034] " fche at redhat dot com
2021-07-07 12:29 ` mark at klomp dot org
2021-07-07 13:45 ` fche at redhat dot com
2021-07-12 19:20 ` nsanci at redhat dot com
2021-08-25 12:33 ` mark at klomp dot org [this message]
2021-08-25 12:34 ` fche at redhat dot com
2021-08-25 12:43 ` mark at klomp dot org
2021-09-27 18:54 ` nsanci at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-28034-10460-RzDh30200B@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).