* [Bug debuginfod/28242] New: extend server http-response metrics with result code
@ 2021-08-17 14:15 fche at redhat dot com
2021-09-10 16:01 ` [Bug debuginfod/28242] " dichen at redhat dot com
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: fche at redhat dot com @ 2021-08-17 14:15 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28242
Bug ID: 28242
Summary: extend server http-response metrics with result code
Product: elfutils
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: debuginfod
Assignee: unassigned at sourceware dot org
Reporter: fche at redhat dot com
CC: elfutils-devel at sourceware dot org
Target Milestone: ---
Now, the http_requests_total{} prometheus metric includes only a
type={debuginfo,...} label, but not a http-result label (like in the
http_responses_* metrics). That makes sense because the metrics are collected
at different times (beginning vs. end of request), but it makes computing
quantities like .... "how many successful debuginfo requests are we serving",
"how large are they"?. We should consider merging the two metrics, or
synthesizing a new one that contains both request classification and success
labeling.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug debuginfod/28242] extend server http-response metrics with result code
2021-08-17 14:15 [Bug debuginfod/28242] New: extend server http-response metrics with result code fche at redhat dot com
@ 2021-09-10 16:01 ` dichen at redhat dot com
2021-09-20 15:47 ` dichen at redhat dot com
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: dichen at redhat dot com @ 2021-09-10 16:01 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28242
Di Chen <dichen at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dichen at redhat dot com
Assignee|unassigned at sourceware dot org |dichen at redhat dot com
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug debuginfod/28242] extend server http-response metrics with result code
2021-08-17 14:15 [Bug debuginfod/28242] New: extend server http-response metrics with result code fche at redhat dot com
2021-09-10 16:01 ` [Bug debuginfod/28242] " dichen at redhat dot com
@ 2021-09-20 15:47 ` dichen at redhat dot com
2021-09-21 16:19 ` [Bug debuginfod/28242] extend server http-response metrics with artifact-type content dichen at redhat dot com
2021-10-06 21:14 ` fche at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: dichen at redhat dot com @ 2021-09-20 15:47 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28242
--- Comment #1 from Di Chen <dichen at redhat dot com> ---
Specifically, this task aims to add another label to all the http_responses_*
metrics.
And they are expecting to be like this:
http_responses_duration_milliseconds_count{code="200", type="debuginfo"} 91300.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug debuginfod/28242] extend server http-response metrics with artifact-type content
2021-08-17 14:15 [Bug debuginfod/28242] New: extend server http-response metrics with result code fche at redhat dot com
2021-09-10 16:01 ` [Bug debuginfod/28242] " dichen at redhat dot com
2021-09-20 15:47 ` dichen at redhat dot com
@ 2021-09-21 16:19 ` dichen at redhat dot com
2021-10-06 21:14 ` fche at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: dichen at redhat dot com @ 2021-09-21 16:19 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28242
Di Chen <dichen at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|extend server http-response |extend server http-response
|metrics with result code |metrics with artifact-type
| |content
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug debuginfod/28242] extend server http-response metrics with artifact-type content
2021-08-17 14:15 [Bug debuginfod/28242] New: extend server http-response metrics with result code fche at redhat dot com
` (2 preceding siblings ...)
2021-09-21 16:19 ` [Bug debuginfod/28242] extend server http-response metrics with artifact-type content dichen at redhat dot com
@ 2021-10-06 21:14 ` fche at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: fche at redhat dot com @ 2021-10-06 21:14 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28242
Frank Ch. Eigler <fche at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Frank Ch. Eigler <fche at redhat dot com> ---
commit 260a3105cc0e378882110ba787cd58815183c454 (HEAD -> master, origin/master,
origin/HEAD)
Author: Di Chen <dichen@redhat.com>
Date: Wed Oct 6 17:04:08 2021 -0400
PR28242: debuginfod prometheus metric widening
This patch aims to extend http_responses_* metrics with another label
"type" by getting the extra artifact-type content added as a new
key=value tag.
v2, tweaked patch to perform artifact-type sanitization at point of
vulnerability rather than in general metric tabulation logic.
Signed-off-by: Di Chen <dichen@redhat.com>
Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-06 21:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-17 14:15 [Bug debuginfod/28242] New: extend server http-response metrics with result code fche at redhat dot com
2021-09-10 16:01 ` [Bug debuginfod/28242] " dichen at redhat dot com
2021-09-20 15:47 ` dichen at redhat dot com
2021-09-21 16:19 ` [Bug debuginfod/28242] extend server http-response metrics with artifact-type content dichen at redhat dot com
2021-10-06 21:14 ` fche at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).