[Bug general/28608] New: elflint elfstrmerge fails with ld.gold

[Bug general/28608] New: elflint elfstrmerge fails with ld.gold

[mliska at suse dot cz]

https://sourceware.org/bugzilla/show_bug.cgi?id=28608

            Bug ID: 28608
           Summary: elflint elfstrmerge fails with ld.gold
           Product: elfutils
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: general
          Assignee: unassigned at sourceware dot org
          Reporter: mliska at suse dot cz
                CC: elfutils-devel at sourceware dot org
  Target Milestone: ---

Using ld.gold, I see the following failure (for GCC 11.2.0):

elflint /home/marxin/Programming/elfutils/tests/elfstrmerge
section [17] '.rodata': merge flag set but entry size is zero
FAIL run-strip-strmerge.sh (exit status: 1)

I configured elfutils with -O2 -g.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug general/28608] elflint elfstrmerge fails with ld.gold

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28608

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
That looks like a bug in ld.gold.

tests/elfstrmerge is a simple ET_EXEC file.
When SHF_MERGE is set, then sh_entsize should be set to the size of the
elements that should be merged (unless SHF_STRING is also set).

For me .rodata doesn't have the SHF_MERGE flag set:
[15] .rodata              PROGBITS     0000000000002d68 00002d68 00000837  0 A 
    0   0  8

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug general/28608] elflint elfstrmerge fails with ld.gold

[mliska at suse dot cz]

https://sourceware.org/bugzilla/show_bug.cgi?id=28608

--- Comment #2 from Martin Liska <mliska at suse dot cz> ---
Thank you for the analysis, can you please open gold bug for it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug general/28608] elflint elfstrmerge fails with ld.gold

[mliska at suse dot cz]

https://sourceware.org/bugzilla/show_bug.cgi?id=28608

--- Comment #3 from Martin Liska <mliska at suse dot cz> ---
It's likely caused by the following 2 sections that are in elfstrmerge.o:

$ readelf -SW elfstrmerge.o | grep rodata
Section Headers:
  [Nr] Name              Type            Address          Off    Size   ES Flg
Lk Inf Al
...
  [ 5] .rodata.str1.1    PROGBITS        0000000000000000 000480 0002d0 01 AMS 
0   0  1
  [ 6] .rodata.str1.8    PROGBITS        0000000000000000 000750 0004df 01 AMS 
0   0  8
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug general/28608] elflint elfstrmerge fails with ld.gold

[mliska at suse dot cz]

https://sourceware.org/bugzilla/show_bug.cgi?id=28608

Martin Liska <mliska at suse dot cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-01-13
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #4 from Martin Liska <mliska at suse dot cz> ---
(In reply to Martin Liska from comment #3)
> It's likely caused by the following 2 sections that are in elfstrmerge.o:
> 
> $ readelf -SW elfstrmerge.o | grep rodata
> Section Headers:
>   [Nr] Name              Type            Address          Off    Size   ES
> Flg Lk Inf Al
> ...
>   [ 5] .rodata.str1.1    PROGBITS        0000000000000000 000480 0002d0 01
> AMS  0   0  1
>   [ 6] .rodata.str1.8    PROGBITS        0000000000000000 000750 0004df 01
> AMS  0   0  8
> ...

This is unrelated, it's a different file that is checked.

So it fails for:
$ /home/marxin/Programming/elfutils/src/elflint --gnu
/home/marxin/Programming/elfutils/tests/elfstrmerge
section [17] '.rodata': merge flag set but entry size is zero

$ readelf -SW /home/marxin/Programming/elfutils/tests/elfstrmerge | grep roda
  [17] .rodata           PROGBITS        0000000000402ea0 002ea0 0007bf 00 AMS 
0   0  8

As seen the section has SHF_STRING flag, thus having sh_entsize == 0 should be
fine.

@Mark: Can you please take a look?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug general/28608] elflint elfstrmerge fails with ld.gold

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28608

--- Comment #5 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Martin Liska from comment #4)
> So it fails for:
> $ /home/marxin/Programming/elfutils/src/elflint --gnu
> /home/marxin/Programming/elfutils/tests/elfstrmerge
> section [17] '.rodata': merge flag set but entry size is zero
> 
> $ readelf -SW /home/marxin/Programming/elfutils/tests/elfstrmerge | grep roda
>   [17] .rodata           PROGBITS        0000000000402ea0 002ea0 0007bf 00
> AMS  0   0  8
> 
> As seen the section has SHF_STRING flag, thus having sh_entsize == 0 should
> be fine.
> 
> @Mark: Can you please take a look?

If both SHF_STRING and SHF_MERGE are set then sh_entsize is the char size
(normally 1).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug general/28608] elflint elfstrmerge fails with ld.gold

[mliska at suse dot cz]

https://sourceware.org/bugzilla/show_bug.cgi?id=28608

Martin Liska <mliska at suse dot cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #6 from Martin Liska <mliska at suse dot cz> ---
Ok, so it's a bug in gold which is not supported much anyway.

-- 
You are receiving this mail because:
You are on the CC list for the bug.