public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
* [Bug libdw/28677] New: Bad dynamic entry conversion in dwfl_link_map_report
@ 2021-12-09 20:14 mark at klomp dot org
  2021-12-09 20:28 ` [Bug libdw/28677] " mark at klomp dot org
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: mark at klomp dot org @ 2021-12-09 20:14 UTC (permalink / raw)
  To: elfutils-devel

https://sourceware.org/bugzilla/show_bug.cgi?id=28677

            Bug ID: 28677
           Summary: Bad dynamic entry conversion in dwfl_link_map_report
           Product: elfutils
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libdw
          Assignee: unassigned at sourceware dot org
          Reporter: mark at klomp dot org
                CC: elfutils-devel at sourceware dot org
  Target Milestone: ---

Created attachment 13841
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13841&action=edit
Corrupt core file

Reproducer from Bug 28666

$ valgrind -q eu-stack --core ./poc2 
==500881== Invalid read of size 8
==500881==    at 0x4851268: __GI_memmove (vg_replace_strmem.c:1271)
==500881==    by 0x48994CB: elf32_xlatetom (in
/usr/lib/aarch64-linux-gnu/libelf-0.183.so)
==500881==    by 0x49232D3: ??? (in /usr/lib/aarch64-linux-gnu/libdw-0.183.so)
==500881==    by 0x4924977: dwfl_core_file_report (in
/usr/lib/aarch64-linux-gnu/libdw-0.183.so)
==500881==    by 0x10AAB7: ??? (in /usr/bin/eu-stack)
==500881==    by 0x4C2ABAF: group_parse (argp-parse.c:257)
==500881==    by 0x4C2ABAF: parser_finalize (argp-parse.c:604)
==500881==    by 0x4C2ABAF: argp_parse (argp-parse.c:922)
==500881==    by 0x10A273: ??? (in /usr/bin/eu-stack)
==500881==    by 0x4B6C217: (below main) (libc-start.c:308)
==500881==  Address 0x4034000 is 0 bytes after the brk data segment limit
0x4034000
==500881== 
==500881== Invalid read of size 8
==500881==    at 0x4851278: __GI_memmove (vg_replace_strmem.c:1271)
==500881==    by 0x48994CB: elf32_xlatetom (in
/usr/lib/aarch64-linux-gnu/libelf-0.183.so)
==500881==    by 0x49232D3: ??? (in /usr/lib/aarch64-linux-gnu/libdw-0.183.so)
==500881==    by 0x4924977: dwfl_core_file_report (in
/usr/lib/aarch64-linux-gnu/libdw-0.183.so)
==500881==    by 0x10AAB7: ??? (in /usr/bin/eu-stack)
==500881==    by 0x4C2ABAF: group_parse (argp-parse.c:257)
==500881==    by 0x4C2ABAF: parser_finalize (argp-parse.c:604)
==500881==    by 0x4C2ABAF: argp_parse (argp-parse.c:922)
==500881==    by 0x10A273: ??? (in /usr/bin/eu-stack)
==500881==    by 0x4B6C217: (below main) (libc-start.c:308)
==500881==  Address 0x4034008 is 8 bytes after the brk data segment limit
0x4034000
==500881== 
==500881== Invalid read of size 8
==500881==    at 0x4851280: __GI_memmove (vg_replace_strmem.c:1271)
==500881==    by 0x48994CB: elf32_xlatetom (in
/usr/lib/aarch64-linux-gnu/libelf-0.183.so)
==500881==    by 0x49232D3: ??? (in /usr/lib/aarch64-linux-gnu/libdw-0.183.so)
==500881==    by 0x4924977: dwfl_core_file_report (in
/usr/lib/aarch64-linux-gnu/libdw-0.183.so)
==500881==    by 0x10AAB7: ??? (in /usr/bin/eu-stack)
==500881==    by 0x4C2ABAF: group_parse (argp-parse.c:257)
==500881==    by 0x4C2ABAF: parser_finalize (argp-parse.c:604)
==500881==    by 0x4C2ABAF: argp_parse (argp-parse.c:922)
==500881==    by 0x10A273: ??? (in /usr/bin/eu-stack)
==500881==    by 0x4B6C217: (below main) (libc-start.c:308)
==500881==  Address 0x4034010 is 16 bytes after the brk data segment limit
0x4034000
==500881== 
==500881== Invalid read of size 8
==500881==    at 0x4851288: __GI_memmove (vg_replace_strmem.c:1271)
==500881==    by 0x48994CB: elf32_xlatetom (in
/usr/lib/aarch64-linux-gnu/libelf-0.183.so)
==500881==    by 0x49232D3: ??? (in /usr/lib/aarch64-linux-gnu/libdw-0.183.so)
==500881==    by 0x4924977: dwfl_core_file_report (in
/usr/lib/aarch64-linux-gnu/libdw-0.183.so)
==500881==    by 0x10AAB7: ??? (in /usr/bin/eu-stack)
==500881==    by 0x4C2ABAF: group_parse (argp-parse.c:257)
==500881==    by 0x4C2ABAF: parser_finalize (argp-parse.c:604)
==500881==    by 0x4C2ABAF: argp_parse (argp-parse.c:922)
==500881==    by 0x10A273: ??? (in /usr/bin/eu-stack)
==500881==    by 0x4B6C217: (below main) (libc-start.c:308)
==500881==  Address 0x4034018 is 24 bytes after the brk data segment limit
0x4034000

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libdw/28677] Bad dynamic entry conversion in dwfl_link_map_report
  2021-12-09 20:14 [Bug libdw/28677] New: Bad dynamic entry conversion in dwfl_link_map_report mark at klomp dot org
@ 2021-12-09 20:28 ` mark at klomp dot org
  2021-12-09 21:27 ` evvers at ya dot ru
  2021-12-10 10:14 ` mark at klomp dot org
  2 siblings, 0 replies; 4+ messages in thread
From: mark at klomp dot org @ 2021-12-09 20:28 UTC (permalink / raw)
  To: elfutils-devel

https://sourceware.org/bugzilla/show_bug.cgi?id=28677

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at sourceware dot org   |mark at klomp dot org

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
Proposed patch:
https://sourceware.org/pipermail/elfutils-devel/2021q4/004507.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libdw/28677] Bad dynamic entry conversion in dwfl_link_map_report
  2021-12-09 20:14 [Bug libdw/28677] New: Bad dynamic entry conversion in dwfl_link_map_report mark at klomp dot org
  2021-12-09 20:28 ` [Bug libdw/28677] " mark at klomp dot org
@ 2021-12-09 21:27 ` evvers at ya dot ru
  2021-12-10 10:14 ` mark at klomp dot org
  2 siblings, 0 replies; 4+ messages in thread
From: evvers at ya dot ru @ 2021-12-09 21:27 UTC (permalink / raw)
  To: elfutils-devel

https://sourceware.org/bugzilla/show_bug.cgi?id=28677

Evgeny Vereshchagin <evvers at ya dot ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |evvers at ya dot ru

--- Comment #2 from Evgeny Vereshchagin <evvers at ya dot ru> ---
(In reply to Mark Wielaard from comment #1)
> Proposed patch:
> https://sourceware.org/pipermail/elfutils-devel/2021q4/004507.html

With that patch applied I can no longer reproduce the issue. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libdw/28677] Bad dynamic entry conversion in dwfl_link_map_report
  2021-12-09 20:14 [Bug libdw/28677] New: Bad dynamic entry conversion in dwfl_link_map_report mark at klomp dot org
  2021-12-09 20:28 ` [Bug libdw/28677] " mark at klomp dot org
  2021-12-09 21:27 ` evvers at ya dot ru
@ 2021-12-10 10:14 ` mark at klomp dot org
  2 siblings, 0 replies; 4+ messages in thread
From: mark at klomp dot org @ 2021-12-10 10:14 UTC (permalink / raw)
  To: elfutils-devel

https://sourceware.org/bugzilla/show_bug.cgi?id=28677

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Mark Wielaard <mark at klomp dot org> ---
Thanks for testing. Applied as:

commit 78ecba0926216e0ad90b71f789636d1e0a9777ca
Author: Mark Wielaard <mark@klomp.org>
Date:   Thu Dec 9 21:24:18 2021 +0100

    libdwfl: Don't try to convert too many dyns in dwfl_link_map_report

    When trying to read (corrupt) dynamic entries from a core file we only
    want to read and convert the entries we could read. Also make sure we
    don't try to allocate too bug a buffer.

    Signed-off-by: Mark Wielaard <mark@klomp.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-10 10:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-09 20:14 [Bug libdw/28677] New: Bad dynamic entry conversion in dwfl_link_map_report mark at klomp dot org
2021-12-09 20:28 ` [Bug libdw/28677] " mark at klomp dot org
2021-12-09 21:27 ` evvers at ya dot ru
2021-12-10 10:14 ` mark at klomp dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).