* [Bug debuginfod/31248] New: debuginfod_find_* may return fd with file-offset at end @ 2024-01-16 1:39 fche at redhat dot com 2024-01-16 12:47 ` [Bug debuginfod/31248] " mark at klomp dot org 2024-01-16 21:47 ` fche at redhat dot com 0 siblings, 2 replies; 3+ messages in thread From: fche at redhat dot com @ 2024-01-16 1:39 UTC (permalink / raw) To: elfutils-devel https://sourceware.org/bugzilla/show_bug.cgi?id=31248 Bug ID: 31248 Summary: debuginfod_find_* may return fd with file-offset at end Product: elfutils Version: unspecified Status: NEW Severity: normal Priority: P2 Component: debuginfod Assignee: unassigned at sourceware dot org Reporter: fche at redhat dot com CC: elfutils-devel at sourceware dot org Target Milestone: --- During the srcfiles test case diagnosis, studying the reason for occasional 0-length files, found something funky about the debuginfod_find_FOO api. It appears possible for first-time-downloaded files to result in FDs that were freshly written into by curl, with the file offset positioned right at the end. We should lseek(2) to the front. Clients would expect to be able to read it, as opposed to an insta-EOF. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug debuginfod/31248] debuginfod_find_* may return fd with file-offset at end 2024-01-16 1:39 [Bug debuginfod/31248] New: debuginfod_find_* may return fd with file-offset at end fche at redhat dot com @ 2024-01-16 12:47 ` mark at klomp dot org 2024-01-16 21:47 ` fche at redhat dot com 1 sibling, 0 replies; 3+ messages in thread From: mark at klomp dot org @ 2024-01-16 12:47 UTC (permalink / raw) To: elfutils-devel https://sourceware.org/bugzilla/show_bug.cgi?id=31248 Mark Wielaard <mark at klomp dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mark at klomp dot org --- Comment #1 from Mark Wielaard <mark at klomp dot org> --- Frank has a fix here, on Housam's try branch, which looks reasonable to me: https://sourceware.org/cgit/elfutils/commit/?h=users/halamour/try-pr30991&id=c742bdc6815e64f64a37f06244cce723b2c817ea -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug debuginfod/31248] debuginfod_find_* may return fd with file-offset at end 2024-01-16 1:39 [Bug debuginfod/31248] New: debuginfod_find_* may return fd with file-offset at end fche at redhat dot com 2024-01-16 12:47 ` [Bug debuginfod/31248] " mark at klomp dot org @ 2024-01-16 21:47 ` fche at redhat dot com 1 sibling, 0 replies; 3+ messages in thread From: fche at redhat dot com @ 2024-01-16 21:47 UTC (permalink / raw) To: elfutils-devel https://sourceware.org/bugzilla/show_bug.cgi?id=31248 Frank Ch. Eigler <fche at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Frank Ch. Eigler <fche at redhat dot com> --- commit 7554d41cd3784a321751c9ac430ad123f6c8cc1e (HEAD -> master3, origin/main) gpg: Signature made Tue 16 Jan 2024 04:46:13 PM EST gpg: using RSA key 4DD136490411C0A42B28844F258B6EFA0F209D24 gpg: Good signature from "Frank Ch. Eigler <fche@elastic.org>" [ultimate] Author: Frank Ch. Eigler <fche@redhat.com> Date: Mon Jan 15 21:21:24 2024 -0500 PR31248: debuginfod_find_*: lseek to the front on returned fds Previous code could return a fd that had its file-offset left at the place where libcurl last used it, namely at the end of the freshly downloaded file. Not good if a client just wants to read it right away! We now ensure (and document) that the fd is pointed to the beginning of the file. Signed-off-by: Frank Ch. Eigler <fche@redhat.com> -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-16 21:47 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-01-16 1:39 [Bug debuginfod/31248] New: debuginfod_find_* may return fd with file-offset at end fche at redhat dot com 2024-01-16 12:47 ` [Bug debuginfod/31248] " mark at klomp dot org 2024-01-16 21:47 ` fche at redhat dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).