[Bug debuginfod/31637] New: segmentation fault when calling 'debuginfod-find -v'

[Bug debuginfod/31637] New: segmentation fault when calling 'debuginfod-find -v'

[nolange79 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31637

            Bug ID: 31637
           Summary: segmentation fault when calling 'debuginfod-find -v'
           Product: elfutils
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: debuginfod
          Assignee: unassigned at sourceware dot org
          Reporter: nolange79 at gmail dot com
                CC: elfutils-devel at sourceware dot org
  Target Milestone: ---

Little to add, bug is reproducible in 188 and 191.


#0  __strcmp_avx2 () at ../sysdeps/x86_64/multiarch/strcmp-avx2.S:283
#1  0x000055555555630c in main (argc=2, argv=0x7fffffffe178) at
/tmp/elfutils-latest/elfutils-0.191/debuginfod/debuginfod-find.c:194

Bug is this line:

if (strcmp(argv[remaining], "debuginfo") == 0)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/31637] segmentation fault when calling 'debuginfod-find -v'

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31637

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |fche at redhat dot com

--- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> ---
Fixed with commit d9f38a7052c22c7762aa5b98b401e8a324336bce, committed as
obvious.

diff --git a/debuginfod/debuginfod-find.c b/debuginfod/debuginfod-find.c
index 307310988c4c..080dd8f2c6a3 100644
--- a/debuginfod/debuginfod-find.c
+++ b/debuginfod/debuginfod-find.c
@@ -136,7 +136,7 @@ main(int argc, char** argv)
   int remaining;
   (void) argp_parse (&argp, argc, argv, ARGP_IN_ORDER|ARGP_NO_ARGS,
&remaining, NULL);

-  if (argc < 2 || remaining+1 == argc) /* no arguments or at least two
non-option words */
+  if (argc < 2 || remaining+1 >= argc) /* no arguments or at least two
non-option words */


and a little test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.