public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: John Gallagher <john@gllghr.com>, elfutils-devel@sourceware.org
Subject: Re: [PATCH] libdwfl: Fix memory leak in unzip()
Date: Mon, 08 May 2023 18:12:05 +0200	[thread overview]
Message-ID: <ca40b63c9395d1b89dbfe49e3a633f487533e276.camel@klomp.org> (raw)
In-Reply-To: <ZEth7/K1GwOAAMS/@localhost.localdomain>

Hi John,

On Thu, 2023-04-27 at 23:04 -0700, John Gallagher wrote:
> state.input_buffer is not freed if the file is found to not be
> compressed with the compression algorithm unzip() is trying to use.

Thanks, pushed. It is clearly correct to call fail here.
Although in all my tests input_buffer was always NULL.

Cheers,

Mark

      reply	other threads:[~2023-05-08 16:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28  6:04 John Gallagher
2023-05-08 16:12 ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca40b63c9395d1b89dbfe49e3a633f487533e276.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=john@gllghr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).