From: Shahab Vahedi <Shahab.Vahedi@synopsys.com>
To: "elfutils-devel@sourceware.org" <elfutils-devel@sourceware.org>
Cc: Shahab Vahedi <Shahab.Vahedi@synopsys.com>
Subject: [PATCH] libdwfl: name dwfl_get_debuginfod_client stub's arg
Date: Mon, 18 Jul 2022 17:33:49 +0000 [thread overview]
Message-ID: <e1f27ec9-3fbd-d3f2-6d98-685956e82662@synopsys.com> (raw)
Since the stub version of "dwfl_get_debuginfod_client" doesn't name its
parameter, building elfuitls fails on a system with gcc 10.2.1:
-----------------------------------------------------------------------------
$ ./configure ... --disable-libdebuginfod
$ make
Making all in libdwfl
CC debuginfod-client.o
/src/libdwfl/debuginfod-client.c: In function 'dwfl_get_debuginfod_client':
/src/libdwfl/debuginfod-client.c:145:29: error: parameter name omitted
145 | dwfl_get_debuginfod_client (Dwfl *)
| ^~~~~~
make[2]: *** [Makefile:707: debuginfod-client.o] Error 1
-----------------------------------------------------------------------------
This fixes the issue by providing a name for the unused parameter.
Signed-off-by: Shahab Vahedi <shahab@synopsys.com>
---
libdwfl/ChangeLog | 5 +++++
libdwfl/debuginfod-client.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index 6ade1afc..75c53948 100644
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,3 +1,8 @@
+2022-07-18 Shahab Vahedi <shahab@synopsys.com>
+
+ * debuginfod-client.c (dwfl_get_debuginfod_client stub):
+ Add a name to the sole parameter.
+
2022-07-13 Mark Wielaard <mark@klomp.org>
* debuginfod-client.c (dwfl_get_debuginfod_client): Add INTDEF.
diff --git a/libdwfl/debuginfod-client.c b/libdwfl/debuginfod-client.c
index 87af73a7..d581daab 100644
--- a/libdwfl/debuginfod-client.c
+++ b/libdwfl/debuginfod-client.c
@@ -142,7 +142,7 @@ __libdwfl_debuginfod_init (void)
#else // ENABLE_LIBDEBUGINFOD
debuginfod_client *
-dwfl_get_debuginfod_client (Dwfl *)
+dwfl_get_debuginfod_client (Dwfl *dummy __attribute__ ((unused)))
{
return NULL;
}
--
2.30.2
next reply other threads:[~2022-07-18 17:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 17:33 Shahab Vahedi [this message]
2022-07-18 17:46 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1f27ec9-3fbd-d3f2-6d98-685956e82662@synopsys.com \
--to=shahab.vahedi@synopsys.com \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).