* [PATCH] libdwfl: name dwfl_get_debuginfod_client stub's arg
@ 2022-07-18 17:33 Shahab Vahedi
2022-07-18 17:46 ` Frank Ch. Eigler
0 siblings, 1 reply; 2+ messages in thread
From: Shahab Vahedi @ 2022-07-18 17:33 UTC (permalink / raw)
To: elfutils-devel; +Cc: Shahab Vahedi
Since the stub version of "dwfl_get_debuginfod_client" doesn't name its
parameter, building elfuitls fails on a system with gcc 10.2.1:
-----------------------------------------------------------------------------
$ ./configure ... --disable-libdebuginfod
$ make
Making all in libdwfl
CC debuginfod-client.o
/src/libdwfl/debuginfod-client.c: In function 'dwfl_get_debuginfod_client':
/src/libdwfl/debuginfod-client.c:145:29: error: parameter name omitted
145 | dwfl_get_debuginfod_client (Dwfl *)
| ^~~~~~
make[2]: *** [Makefile:707: debuginfod-client.o] Error 1
-----------------------------------------------------------------------------
This fixes the issue by providing a name for the unused parameter.
Signed-off-by: Shahab Vahedi <shahab@synopsys.com>
---
libdwfl/ChangeLog | 5 +++++
libdwfl/debuginfod-client.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index 6ade1afc..75c53948 100644
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,3 +1,8 @@
+2022-07-18 Shahab Vahedi <shahab@synopsys.com>
+
+ * debuginfod-client.c (dwfl_get_debuginfod_client stub):
+ Add a name to the sole parameter.
+
2022-07-13 Mark Wielaard <mark@klomp.org>
* debuginfod-client.c (dwfl_get_debuginfod_client): Add INTDEF.
diff --git a/libdwfl/debuginfod-client.c b/libdwfl/debuginfod-client.c
index 87af73a7..d581daab 100644
--- a/libdwfl/debuginfod-client.c
+++ b/libdwfl/debuginfod-client.c
@@ -142,7 +142,7 @@ __libdwfl_debuginfod_init (void)
#else // ENABLE_LIBDEBUGINFOD
debuginfod_client *
-dwfl_get_debuginfod_client (Dwfl *)
+dwfl_get_debuginfod_client (Dwfl *dummy __attribute__ ((unused)))
{
return NULL;
}
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-18 17:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-18 17:33 [PATCH] libdwfl: name dwfl_get_debuginfod_client stub's arg Shahab Vahedi
2022-07-18 17:46 ` Frank Ch. Eigler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).