Re: [PATCH] Accept DW_AT_GNU_call_site_* as attributes that hold location expressions

Re: [PATCH] Accept DW_AT_GNU_call_site_* as attributes that hold location expressions

[Petr Machata]

[-- Attachment #1: Type: text/plain, Size: 91 bytes --]

Roland McGrath <roland@hack.frob.com> writes:

> Looks right.

Pushed.

Thanks,
PM

Re: [PATCH] Accept DW_AT_GNU_call_site_* as attributes that hold location expressions

[Roland McGrath]

[-- Attachment #1: Type: text/plain, Size: 14 bytes --]

Looks right.

[PATCH] Accept DW_AT_GNU_call_site_* as attributes that hold location expressions

[Petr Machata]

[-- Attachment #1: Type: text/plain, Size: 1677 bytes --]

- These are extension attributes that correspond in behavior to
  attributes described in this proposal:
	http://www.dwarfstd.org/ShowIssue.php?issue=100909.2

- N.B.: DW_AT_call_site_data_location doesn't have a DW_AT_GNU_*
  counterpart.

Signed-off-by: Petr Machata <pmachata@redhat.com>
---
 libdw/ChangeLog           |    6 ++++++
 libdw/dwarf_getlocation.c |    6 +++++-
 2 files changed, 11 insertions(+), 1 deletions(-)

diff --git a/libdw/ChangeLog b/libdw/ChangeLog
index 5f9b097..cc44004 100644
--- a/libdw/ChangeLog
+++ b/libdw/ChangeLog
@@ -1,3 +1,9 @@
+2014-09-10  Petr Machata  <pmachata@redhat.com>
+
+	* dwarf_getlocation.c (attr_ok): Also accept
+	DW_AT_GNU_call_site_value, DW_AT_GNU_call_site_data_value,
+	DW_AT_GNU_call_site_target, DW_AT_GNU_call_site_target_clobbered.
+
 2014-08-15  Mark Wielaard  <mjw@redhat.com>
 
 	* dwarf_cu_die.c: New file.
diff --git a/libdw/dwarf_getlocation.c b/libdw/dwarf_getlocation.c
index 8dffb83..2a4c890 100644
--- a/libdw/dwarf_getlocation.c
+++ b/libdw/dwarf_getlocation.c
@@ -1,5 +1,5 @@
 /* Return location expression list.
-   Copyright (C) 2000-2010, 2013 Red Hat, Inc.
+   Copyright (C) 2000-2010, 2013, 2014 Red Hat, Inc.
    This file is part of elfutils.
    Written by Ulrich Drepper <drepper@redhat.com>, 2000.
 
@@ -57,6 +57,10 @@ attr_ok (Dwarf_Attribute *attr)
     case DW_AT_return_addr:
     case DW_AT_static_link:
     case DW_AT_segment:
+    case DW_AT_GNU_call_site_value:
+    case DW_AT_GNU_call_site_data_value:
+    case DW_AT_GNU_call_site_target:
+    case DW_AT_GNU_call_site_target_clobbered:
       break;
 
     default:
-- 
1.7.6.5