From: Tobias Burnus <tobias@codesourcery.com>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: rank checking with explicit-/assumed-size arrays and CLASS [PR58331]
Date: Wed, 15 Mar 2023 10:10:44 +0100 [thread overview]
Message-ID: <099717a7-2de0-c71a-f9fa-58095e691898@codesourcery.com> (raw)
In-Reply-To: <trinity-0a97ee57-2800-4785-b4b4-418bbb32675c-1678822727185@3c-app-gmx-bap12>
Hi Harald,
On 14.03.23 20:38, Harald Anlauf wrote:
> The testcase covers only non-coarray cases, as playing with
> coarray variants hit pre-exisiting issues in gfortran that
> are very likely unrelated to the interface checks.
I concur (but would not rule out additional interface issues).
> I consider this rather as post 13-release stuff.
In any case, the coarray issue can be fixed separately. And I think
post-GCC-13 makes sense.
> Regtested on x86_64-pc-linux-gnu. OK for mainline?
Thanks – LGTM!
> + formal_as = formal->ts.type == BT_CLASS ? CLASS_DATA (formal)->as
> + : formal->as;
> +
(Jakub remarks for such code that some editor (emacs?), he does not use,
mis-<tab>-auto-indent such a code - and proposes to add a parentheses
around the right-hand side of the assignment.)
* * *
I also wonder whether we need some run-time testcase. The interface
check now works and I also tend to write dg-do-compile testcases, but
given what can go wrong with all the array descriptor, class etc
handling, we may want to ensure it works at run time. – Thoughts?
(That's independent of the patch it and could be done as follow up, if
it deemed reasonable. The included testcase is surely compile-only as it
has dg-error checks.)
Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
next prev parent reply other threads:[~2023-03-15 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 19:38 Harald Anlauf
2023-03-15 9:10 ` Tobias Burnus [this message]
2023-03-15 19:36 ` Harald Anlauf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=099717a7-2de0-c71a-f9fa-58095e691898@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).