public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tobias Burnus <tobias@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>, <gcc-patches@gcc.gnu.org>,
	<fortran@gcc.gnu.org>
Subject: Re: [PATCH] fortran: Add -static-libquadmath support [PR46539]
Date: Wed, 17 Aug 2022 09:55:40 +0200	[thread overview]
Message-ID: <123a5acb-052a-377a-4a86-01306c9e24a6@codesourcery.com> (raw)
In-Reply-To: <YvuqJyvOMhN1QSy2@tucnak>

On 16.08.22 16:31, Jakub Jelinek via Gcc-patches wrote:
> The following patch is a revival of the
> https://gcc.gnu.org/legacy-ml/gcc-patches/2014-10/msg00771.html
> patch.  While trunk configured against recent glibc and with linker
> --as-needed support doesn't really need to link against -lquadmath
> anymore, there are still other targets where libquadmath is still in
> use.
> As has been discussed, making -static-libgfortran imply statically
> linking both libgfortran and libquadmath is undesirable because of
> the significant licensing differences between the 2 libraries.
> [...]
> So far slightly tested on x86_64-linux (and will bootstrap/regtest
> it there tonight), but I unfortunately don't have a way to test it
> e.g. on Darwin.
>
> Thoughts on this?

Looks good to me – with the caveat of having only limited knowledge of
.spec and Darwin.

> --- gcc/fortran/invoke.texi.jj        2022-05-09 09:09:20.312473272 +0200
> +++ gcc/fortran/invoke.texi   2022-08-16 16:12:47.638203577 +0200
...
> +Please note that the @file{libquadmath} runtime library is licensed under the
> +GNU Lesser General Public License (LGPL), and linking it statically introduces
> +requirements on redistributing the resulting binaries.

"on redistributing" sounds odd to me – "when redistributing" or "on
(the) redistribution of" sounds better to me.

Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

  parent reply	other threads:[~2022-08-17  7:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16 14:31 Jakub Jelinek
2022-08-17  7:19 ` Jakub Jelinek
2022-08-17  7:55 ` Tobias Burnus [this message]
2022-08-17  8:28 ` Mikael Morin
2022-08-17 11:05   ` [PATCH] fortran, v2: " Jakub Jelinek
2022-08-18 10:35     ` Iain Sandoe
2022-08-18 10:41       ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=123a5acb-052a-377a-4a86-01306c9e24a6@codesourcery.com \
    --to=tobias@codesourcery.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).