From: Jerry DeLisle <jvdelisle@charter.net>
To: Tobias Burnus <tobias@codesourcery.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
fortran <fortran@gcc.gnu.org>
Subject: Re: [Patch] Fortran: Follow fixes to -freal-{4,8}-real* handling [PR99355,PR57871] (was: Re: [Patch] Fortran: Fix -freal-{4,8}-real* handling [PR99355])
Date: Thu, 4 Mar 2021 17:03:08 -0800 [thread overview]
Message-ID: <131e010a-a429-b52e-c7d6-e401306d2c28@charter.net> (raw)
In-Reply-To: <72ad0d5c-762b-351d-6046-bdaf24e714e5@codesourcery.com>
OK, thanks Dominique for spotting this.
On 3/4/21 9:02 AM, Tobias Burnus wrote:
> Dominique found an issue ("regression") with this patch – and a testcase
> omission.
>
> The previous patch mishandled the noncommitted testcase of PR57871 – or
> in other words: It did not promote 1.0_4 or 1.0_8 – as only the
> default-real-kind values 1.0 and 1.0d0 were promoted (via code in in
> trans-types.c).
>
> I have additionally updated the documentation to more accurately state
> what the option does and how it interacts with other options.
>
> OK for mainline?
>
> Tobias
>
> PS: Side remark: My recommendation is to avoid
> -freal-{4,8}-real-{4,8,10,16} ...
>
> -----------------
> Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München
> Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung,
> Frank Thürauf
prev parent reply other threads:[~2021-03-05 1:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 11:45 [Patch] Fortran: Fix -freal-{4,8}-real* handling [PR99355] Tobias Burnus
2021-03-04 2:06 ` Jerry DeLisle
2021-03-04 17:02 ` [Patch] Fortran: Follow fixes to -freal-{4,8}-real* handling [PR99355,PR57871] (was: Re: [Patch] Fortran: Fix -freal-{4,8}-real* handling [PR99355]) Tobias Burnus
2021-03-05 1:03 ` Jerry DeLisle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=131e010a-a429-b52e-c7d6-e401306d2c28@charter.net \
--to=jvdelisle@charter.net \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).