* [Patch] omp_lib.f90.in: Deprecate omp_lock_hint_* for OpenMP 5.0
@ 2023-10-19 19:48 Tobias Burnus
0 siblings, 0 replies; only message in thread
From: Tobias Burnus @ 2023-10-19 19:48 UTC (permalink / raw)
To: gcc-patches, fortran
[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]
I noticed that we only tagged half of the 5.0 deprecations in the omp_lib module;
this added the other half. (omp_lock_hint_* was renamed to omp_sync_hint_*.)
Currently, this patch has has no visible effect - but once we bump the OpenMP version
from 4.5 to 5.0, there will warnings of the those.
Comments, remarks? If not, I will commit the attached patch tomorrow.
Tobias
PS: Once the OpenMP version has been bumped (as done for testing), the warning
looks as follows:
1 | use omp_lib
| 1
Warning: Using parameter ‘omp_lock_hint_kind’ declared at (1) is deprecated [-Wdeprecated-declarations]
3 | print *, omp_get_nested()
| 1
Warning: Using function ‘omp_get_nested’ at (1) is deprecated [-Wdeprecated-declarations]
The 'omp_lock_hint_kind' warning is not ideal as it uses the declared-at location
and not the first-used location, which would be in line 2:
integer(omp_lock_hint_kind) :: hint
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
[-- Attachment #2: depr.diff --]
[-- Type: text/x-patch, Size: 1071 bytes --]
omp_lib.f90.in: Deprecate omp_lock_hint_* for OpenMP 5.0
The omp_lock_hint_* parameters were deprecated in favor of
omp_sync_hint_*. While omp.h contained deprecation markers for those,
the omp_lib module only contained them for omp_{g,s}_nested.
Note: The -Wdeprecated-declarations warning will only become active once
openmp_version / _OPENMP is bumped from 201511 (4.5) to 201811 (5.0).
libgomp/ChangeLog:
* omp_lib.f90.in: Tag omp_lock_hint_* as being deprecated when
_OPENMP >= 201811.
diff --git a/libgomp/omp_lib.f90.in b/libgomp/omp_lib.f90.in
index e4515271252..755c0bf16ec 100644
--- a/libgomp/omp_lib.f90.in
+++ b/libgomp/omp_lib.f90.in
@@ -904,6 +904,10 @@
#if _OPENMP >= 201811
!GCC$ ATTRIBUTES DEPRECATED :: omp_get_nested, omp_set_nested
+!GCC$ ATTRIBUTES DEPRECATED :: omp_lock_hint_kind, omp_lock_hint_none
+!GCC$ ATTRIBUTES DEPRECATED :: omp_lock_hint_uncontended, omp_lock_hint_contended
+!GCC$ ATTRIBUTES DEPRECATED :: omp_lock_hint_nonspeculative
+!GCC$ ATTRIBUTES DEPRECATED :: omp_lock_hint_speculative
#endif
#if _OPENMP >= 202011
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-10-19 19:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-19 19:48 [Patch] omp_lib.f90.in: Deprecate omp_lock_hint_* for OpenMP 5.0 Tobias Burnus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).