From: Eric Botcazou <botcazou@adacore.com>
To: Tobias Burnus <Tobias_Burnus@mentor.com>
Cc: gcc-patches@gcc.gnu.org, fortran <fortran@gcc.gnu.org>
Subject: Re: [patch] Fix PR fortran/96983
Date: Wed, 10 Mar 2021 12:34:42 +0100 [thread overview]
Message-ID: <1978065.on9YKFqRqg@fomalhaut> (raw)
In-Reply-To: <3ffe91c1-4da4-ecd9-1d16-c0135af1c3e9@mentor.com>
> I think it is a bad idea to hard-code the real type.
> Does the following work for you? If so, I think that
> patch is obvious and you can go ahead and commit it.
>
> --- a/gcc/fortran/trans-intrinsic.c
> +++ b/gcc/fortran/trans-intrinsic.c
> @@ -407,7 +407,7 @@ build_round_expr (tree arg, tree restype)
> if (kind < 0)
> gfc_internal_error ("Could not find real kind with at least %d
> bits", resprec);
> - arg = fold_convert (gfc_float128_type_node, arg);
> + arg = fold_convert (gfc_get_real_type (kind), arg);
> fn = gfc_builtin_decl_for_float_kind (BUILT_IN_ROUND, kind);
> }
> else
Yes, it works fine on x86-64/Linux and SPARC64/Linux, applied, thanks.
--
Eric Botcazou
prev parent reply other threads:[~2021-03-10 11:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 16:25 Eric Botcazou
2021-03-10 9:23 ` Tobias Burnus
2021-03-10 11:34 ` Eric Botcazou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1978065.on9YKFqRqg@fomalhaut \
--to=botcazou@adacore.com \
--cc=Tobias_Burnus@mentor.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).