From: Eric Botcazou <botcazou@adacore.com>
To: fortran <fortran@gcc.gnu.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: [patch] Fix PR fortran/96983
Date: Mon, 08 Mar 2021 17:25:36 +0100 [thread overview]
Message-ID: <5050796.fM2REodTD2@fomalhaut> (raw)
[-- Attachment #1: Type: text/plain, Size: 476 bytes --]
Hi,
AFAICS the code in build_round_expr implicitly assumes that __float128 exists,
which is *not* the common case among 64-bit architectures since "long double"
is generally already 128-bit for them.
Tested on x86-64/Linux and SPARC64/Linux, OK for the mainline?
2021-03-08 Eric Botcazou <ebotcazou@adacore.com>
PR fortran/96983
* trans-intrinsic.c (build_round_expr): Do not implicitly assume
that __float128 is the 128-bit floating-point type.
--
Eric Botcazou
[-- Attachment #2: pr96983.diff --]
[-- Type: text/x-patch, Size: 649 bytes --]
diff --git a/gcc/fortran/trans-intrinsic.c b/gcc/fortran/trans-intrinsic.c
index 5c9258c65c3..ae359a07973 100644
--- a/gcc/fortran/trans-intrinsic.c
+++ b/gcc/fortran/trans-intrinsic.c
@@ -407,7 +407,10 @@ build_round_expr (tree arg, tree restype)
if (kind < 0)
gfc_internal_error ("Could not find real kind with at least %d bits",
resprec);
- arg = fold_convert (gfc_float128_type_node, arg);
+ if (gfc_real16_is_float128)
+ arg = fold_convert (gfc_float128_type_node, arg);
+ else
+ arg = fold_convert (long_double_type_node, arg);
fn = gfc_builtin_decl_for_float_kind (BUILT_IN_ROUND, kind);
}
else
next reply other threads:[~2021-03-08 16:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 16:25 Eric Botcazou [this message]
2021-03-10 9:23 ` Tobias Burnus
2021-03-10 11:34 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5050796.fM2REodTD2@fomalhaut \
--to=botcazou@adacore.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).