Re: git out-of-order commit (was Re: [PATCH] Fortran: Remove unused declaration)

[Harald Anlauf <anlauf@gmx.de>]

Am 19.01.23 um 20:39 schrieb Jason Merrill via Gcc-patches:
> On Sat, Nov 12, 2022 at 4:24 PM Harald Anlauf via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
>>
>> Am 12.11.22 um 22:05 schrieb Bernhard Reutner-Fischer via Gcc-patches:
>>> This function definition was removed years ago, remove it's prototype.
>>>
>>> gcc/fortran/ChangeLog:
>>>
>>>        * gfortran.h (gfc_check_include): Remove declaration.
>>> ---
>>>    gcc/fortran/gfortran.h | 1 -
>>>    1 file changed, 1 deletion(-)
>>> ---
>>> Regtests cleanly, ok for trunk?
>>>
>>> diff --git a/gcc/fortran/gfortran.h b/gcc/fortran/gfortran.h
>>> index c4deec0d5b8..ce3ad61bb52 100644
>>> --- a/gcc/fortran/gfortran.h
>>> +++ b/gcc/fortran/gfortran.h
>>> @@ -3208,7 +3208,6 @@ int gfc_at_eof (void);
>>>    int gfc_at_bol (void);
>>>    int gfc_at_eol (void);
>>>    void gfc_advance_line (void);
>>> -int gfc_check_include (void);
>>>    int gfc_define_undef_line (void);
>>>
>>>    int gfc_wide_is_printable (gfc_char_t);
>>
>> OK, thanks.
>
> Somehow this was applied with a CommitDate in 2021, breaking scripts
> that assume monotonically increasing CommitDate.  Anyone know how that
> could have happened?

It is quite unusual that the CommitDate is before the AuthorDate:

% git show --pretty=fuller 7ce0cee77adf33397d0ba61e7445effd8a5d8fcc |
head -5
commit 7ce0cee77adf33397d0ba61e7445effd8a5d8fcc
Author:     Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
AuthorDate: Sat Nov 6 06:51:00 2021 +0100
Commit:     Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
CommitDate: Sat Nov 6 06:48:00 2021 +0100

Could this have prevented checks to work properly?

Harald

> Jason
>
>