Re: 12 PR fixed

[Steve Kargl <sgk@troutmask.apl.washington.edu>]

On Sun, Mar 14, 2021 at 12:38:59PM +0100, Tobias Burnus wrote:
> On 14.03.21 06:13, Jerry DeLisle wrote:
> 
> > Well, I am seeing the falling upon a closer look.  I do not know if
> > related to the patch yet.  Lets make sure this is fixed.
> > 
> > FAIL: gfortran.dg/pr87907.f90   -O  (internal compiler error)
> > FAIL: gfortran.dg/pr87907.f90   -O  (test for excess errors)
> > FAIL: gfortran.dg/pr96013.f90   -O  (test for excess errors)
> > FAIL: gfortran.dg/pr96025.f90   -O  (internal compiler error)
> > FAIL: gfortran.dg/pr96025.f90   -O   (test for errors, line 5)
> > FAIL: gfortran.dg/pr96025.f90   -O  (test for excess errors)
> 
> I do see the failure with the new patch applied –

Interesting.  I don't see issues, but then again I don't
do git, so something may have gone south in trying to 
generate a patch.  Probably to be expected when patches
ferment in bugzilla.

91960 2021-03-10, patch not in BZ, tipping point, comment longer than code.
93635 2020-02-10, patch comment #2, does not apply cleanly due to changes
95501 2020-06-03, patch comment #1, 1 line, null ptr check
95502 2020-06-03, patch comment #1, 6 lines, 2 null ptr checks
95710 2020-06-17, patch comment #2, 2 null ptr checks, new error msg
96013 2020-06-30, patch comment #6, 10 lines changed
96025 2020-07-01, patch comment #3, 1 line changed, nullifies a typespec (ts).
97122 2020-09-20, patch comment #1, 2 line changed
99256 2021-02-25, patch comment #1, 8 lines, null ptr, new error msg
99349 2021-02-25, patch comment #1, 2 lines deleted
99351 2021-03-03, patch comemnt #1, adds checks on STAT and ERRMSG in SYNCxxx.
99506 (patch for 91960 fixes this one)

None of the above individual patches should have been difficult to review.
All patches, except 91960, developed against svn r280157, so svn vs git
might be an issue.  All testcases not under git control are hand merged
into gcc/gfortran.dg, so again an opportunity for a screw-up.  Took a few
hours to figure out how to generate the posted diff, so again an opportunity
to FU.

95038 Not in mega patch.  Fixes ICE allowing code to compile.  Code should
      issue an error due to missing IMPORT statement in interface.
95372 Not in mega patch.  Change assert() to null ptr check and error msg.
      Harald has assigned this to himself.  Stopped working on bug.
95613 Not in mega patch.  Removes legacy extension of branching to
      to a label in a different block.  Somehow breaks OpenMP.  Don't
      know OpenMP, so cannot judge whether branching to a different block
      is allowed.
95543 Not in mega patch.  Fixes a PDT issue, but PDT are so horribly 
      broken the result produces wrong code.

I also have very old patches for pr30371 and pr69101, which
I have not tried to merge into my local git repository.

I guess I can start over with

% git clone git://gcc.gnu.org/git/gcc.git DIR1
% cp -R DIR1 DIR2
(merge changes into DIR1)
% diff -NR DIR2 DIR1

-- 
steve