From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Jerry DeLisle <jvdelisle@charter.net>
Cc: Tobias Burnus <burnus@net-b.de>, gfortran <fortran@gcc.gnu.org>
Subject: Re: 12 PR fixed
Date: Mon, 15 Mar 2021 15:17:13 -0700 [thread overview]
Message-ID: <20210315221713.GA11256@troutmask.apl.washington.edu> (raw)
In-Reply-To: <1181acdb-05de-6ad4-16d3-79c9a932c3f2@charter.net>
On Sun, Mar 14, 2021 at 08:22:58AM -0700, Jerry DeLisle wrote:
> > > >
> > > > FAIL: gfortran.dg/pr87907.f90 -O (internal compiler error)
> > > > FAIL: gfortran.dg/pr87907.f90 -O (test for excess errors)
> > > > FAIL: gfortran.dg/pr96013.f90 -O (test for excess errors)
> > > > FAIL: gfortran.dg/pr96025.f90 -O (internal compiler error)
> > > > FAIL: gfortran.dg/pr96025.f90 -O (test for errors, line 5)
> > > > FAIL: gfortran.dg/pr96025.f90 -O (test for excess errors)
> > >
No idea why I don't see the above. This patch on top of
the previous patch might fix the last 3 FAILs. (Watch
for copy-n-paste whitespace corruption.)
diff --git a/gcc/fortran/expr.c b/gcc/fortran/expr.c
index e1acc2db000..081487a45e6 100644
--- a/gcc/fortran/expr.c
+++ b/gcc/fortran/expr.c
@@ -3476,7 +3476,6 @@ gfc_specification_expr (gfc_expr *e)
{
gfc_error ("Expression at %L must be of INTEGER type, found %s",
&e->where, gfc_basic_typename (e->ts.type));
- gfc_clear_ts (&e->ts);
return false;
}
@@ -5246,11 +5245,12 @@ gfc_traverse_expr (gfc_expr *expr, gfc_symbol *sym,
if ((*func) (expr, sym, &f))
return true;
- if (expr->ts.type == BT_CHARACTER
- && expr->ts.u.cl
- && expr->ts.u.cl->length
- && expr->ts.u.cl->length->expr_type != EXPR_CONSTANT
- && gfc_traverse_expr (expr->ts.u.cl->length, sym, func, f))
+ if (expr->expr_type != EXPR_CONSTANT
+ && expr->ts.type == BT_CHARACTER
+ && expr->ts.u.cl
+ && expr->ts.u.cl->length
+ && expr->ts.u.cl->length->expr_type != EXPR_CONSTANT
+ && gfc_traverse_expr (expr->ts.u.cl->length, sym, func, f))
return true;
switch (expr->expr_type)
--
steve
next prev parent reply other threads:[~2021-03-15 22:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 21:33 Steve Kargl
2021-03-14 4:46 ` Jerry DeLisle
2021-03-14 5:13 ` Jerry DeLisle
2021-03-14 6:05 ` Steve Kargl
2021-03-14 11:38 ` Tobias Burnus
2021-03-14 12:01 ` Tobias Burnus
2021-03-14 15:22 ` Jerry DeLisle
2021-03-15 22:17 ` Steve Kargl [this message]
2021-03-14 16:46 ` Steve Kargl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315221713.GA11256@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=burnus@net-b.de \
--cc=fortran@gcc.gnu.org \
--cc=jvdelisle@charter.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).