From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Harald Anlauf <anlauf@gmx.de>
Cc: rep.dot.nop@gmail.com, fortran@gcc.gnu.org
Subject: Re: [PATCH,FORTRAN] Fix memory leak of gsymbol
Date: Sun, 31 Oct 2021 21:25:44 +0100 [thread overview]
Message-ID: <20211031212544.043daf3a@nbbrfq> (raw)
In-Reply-To: <2ffbe5d9-88d2-e9a9-4f2b-1c3944b87d76@gmx.de>
On Sun, 31 Oct 2021 20:46:07 +0100
Harald Anlauf <anlauf@gmx.de> wrote:
> Am 30.10.21 um 23:51 schrieb Bernhard Reutner-Fischer via Fortran:
> >>> The only caller is translate_all_program_units.
> >>> Since we free only module gsyms, even -fdump-fortran-global is
> >>> unaffected by this, fwiw.
> >
> > AFAICS we do not have a test for -fdump-fortran-global
> > Do we want to add one, would the attached be OK?
>
> This doesn't seem to test anything new or changed, or a bug fixed.
> I get the same result for all version from 9 to 12-mainline.
> So as is it seems pointless.
Yes indeed, it just adds coverage to that functionality which we did not
exercise before.
TBH i only found that option when looking around
translate_all_program_units. I've never actually used that option
myself and cannot imagine how it is useful at all :)
Dropped the testcase.
Thanks for your comment!
cheers,
next prev parent reply other threads:[~2021-10-31 20:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-21 14:04 Bernhard Reutner-Fischer
2021-10-27 21:43 ` Bernhard Reutner-Fischer
2021-10-28 21:37 ` Harald Anlauf
2021-10-28 23:23 ` Bernhard Reutner-Fischer
2021-10-30 16:52 ` Bernhard Reutner-Fischer
2021-10-30 21:51 ` Bernhard Reutner-Fischer
2021-10-31 19:46 ` Harald Anlauf
2021-10-31 19:46 ` Harald Anlauf
2021-10-31 20:25 ` Bernhard Reutner-Fischer [this message]
2023-02-25 21:55 ` drop -fdump-fortran-global ? [was: Re: [PATCH,FORTRAN] Fix memory leak of gsymbol] Bernhard Reutner-Fischer
2023-02-25 22:59 ` Thomas König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211031212544.043daf3a@nbbrfq \
--to=rep.dot.nop@gmail.com \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).