From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Harald Anlauf <anlauf@gmx.de>
Cc: rep.dot.nop@gmail.com, fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH,FORTRAN] Fix memory leak of gsymbol
Date: Fri, 29 Oct 2021 01:23:02 +0200 [thread overview]
Message-ID: <20211029012302.052fc4c4@nbbrfq> (raw)
In-Reply-To: <d1eaf6a3-0a11-bbab-9da5-2900f8bb7f2e@gmx.de>
On Thu, 28 Oct 2021 23:37:59 +0200
Harald Anlauf <anlauf@gmx.de> wrote:
> Hi Bernhard,
>
> Am 27.10.21 um 23:43 schrieb Bernhard Reutner-Fischer via Gcc-patches:
> > ping
> > [I'll rebase and retest this too since it's been a while.
> > Ok if it passes?]
> >
> > On Sun, 21 Oct 2018 16:04:34 +0200
> > Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote:
> >> gcc/fortran/ChangeLog:
> >>
> >> 2018-10-21 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
> >>
> >> * parse.c (clean_up_modules): Free gsym.
> this essentially looks fine, but did you inspect the callers?
>
> With the change to the interface (*gsym -> *&gsym), it could have
> effects not visible here due to the explicit gsym = NULL.
>
> Assuming you checked that, and if it regtests fine, then it is
> OK for mainline.
The only caller is translate_all_program_units.
Since we free only module gsyms, even -fdump-fortran-global is
unaffected by this, fwiw.
It regtests cleanly and i will push it when the rest is approved.
Thanks!
next prev parent reply other threads:[~2021-10-28 23:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-21 14:04 Bernhard Reutner-Fischer
2021-10-27 21:43 ` Bernhard Reutner-Fischer
2021-10-28 21:37 ` Harald Anlauf
2021-10-28 23:23 ` Bernhard Reutner-Fischer [this message]
2021-10-30 16:52 ` Bernhard Reutner-Fischer
2021-10-30 21:51 ` Bernhard Reutner-Fischer
2021-10-31 19:46 ` Harald Anlauf
2021-10-31 19:46 ` Harald Anlauf
2021-10-31 20:25 ` Bernhard Reutner-Fischer
2023-02-25 21:55 ` drop -fdump-fortran-global ? [was: Re: [PATCH,FORTRAN] Fix memory leak of gsymbol] Bernhard Reutner-Fischer
2023-02-25 22:59 ` Thomas König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211029012302.052fc4c4@nbbrfq \
--to=rep.dot.nop@gmail.com \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).