From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: FX <fxcoudert@gmail.com>, fortran@gcc.gnu.org
Subject: Re: New signaling NaN causes 12 testsuite failures
Date: Wed, 26 Jan 2022 08:02:31 -0800 [thread overview]
Message-ID: <20220126160231.GA42566@troutmask.apl.washington.edu> (raw)
In-Reply-To: <33b4ec6c-5867-6eab-6200-02a964c43ccd@codesourcery.com>
On Wed, Jan 26, 2022 at 11:47:27AM +0100, Tobias Burnus wrote:
> On 25.01.22 21:56, FX via Fortran wrote:
> > What I wonder is: if those conditions failed, then the struct they define should have been empty, and therefore the code shouldn’t compile anyway (that was the intent).
>
> Wouldn't it make more sense to add '#else' / '#error "...."' in that case?
>
AFAICT, the first condition does not fail due to the missing
trailing underscores.
#if __FLOAT_WORD_ORDER == __BIG_ENDIAN
becomes (I believe)
#if 0 == 0
so FreeBSD was using big endian in FX's issignaling_fallback
when it needed little endian.
PS: Thanks FX for your patch!
--
Steve
next prev parent reply other threads:[~2022-01-26 16:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 0:44 Steve Kargl
2022-01-25 2:48 ` Steve Kargl
2022-01-25 8:05 ` FX
2022-01-25 17:42 ` Steve Kargl
2022-01-25 19:59 ` Steve Kargl
2022-01-25 20:04 ` FX
2022-01-25 20:20 ` Steve Kargl
2022-01-25 8:09 ` FX
2022-01-25 16:52 ` Steve Kargl
2022-01-25 19:35 ` Steve Kargl
2022-01-25 19:52 ` FX
2022-01-25 20:12 ` Steve Kargl
2022-01-25 20:45 ` Steve Kargl
2022-01-25 20:56 ` FX
2022-01-25 21:05 ` Steve Kargl
2022-01-25 23:11 ` FX
2022-01-26 10:47 ` Tobias Burnus
2022-01-26 16:02 ` Steve Kargl [this message]
2022-01-26 16:19 ` FX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126160231.GA42566@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
--cc=fxcoudert@gmail.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).