public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: fortran@gcc.gnu.org
Subject: Re: [PATCH] Fortran: fix simplification of INDEX(str1,str2) [PR105691]
Date: Sun, 26 Jun 2022 22:22:56 +0200	[thread overview]
Message-ID: <e3c8caee-55ec-1fbd-b1a5-858064fe17b5@gmx.de> (raw)
Message-ID: <20220626202256.3itTm9FLMOJP7gNM8p74lYfmCiEVdLuDdJsUvWbLcmg@z> (raw)
In-Reply-To: <901c2c54-57a9-92ac-59e1-535a1f4227c6@netcologne.de>

Hi Thomas,

thanks for the reviews!

Harald

Am 26.06.22 um 11:14 schrieb Thomas Koenig via Fortran:
> Hello Harald,
> 
>> compile time simplification of INDEX(str1,str2,back=.true.) gave wrong
>> results.  Looking at gfc_simplify_index, this appeared to be close to
>> a complete mess, while the runtime library code - which was developed
>> later - was a relief.
>>
>> The solution is to use the runtime library code as template to fix this.
>> I took the opportunity to change string index and length variables
>> in gfc_simplify_index to HOST_WIDE_INT.
>>
>> Regtested on x86_64-pc-linux-gnu.  OK for mainline?
>>
>> As this is a wrong-code issue, would this qualify for backports to
>> open branches?
> 
> OK for both.
> 
> Thanks for the patch!
> 
> 
> Best regards
> 
>      Thomas
> 



  reply	other threads:[~2022-06-26 20:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21 21:27 Harald Anlauf
2022-06-26  9:14 ` Thomas Koenig
2022-06-26 20:22   ` Harald Anlauf [this message]
2022-06-26 20:22     ` Harald Anlauf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3c8caee-55ec-1fbd-b1a5-858064fe17b5@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).