public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tobias Burnus <tobias@codesourcery.com>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: improve error recovery while simplifying size of bad array [PR103694]
Date: Wed, 24 Aug 2022 19:54:22 +0200	[thread overview]
Message-ID: <df717057-9d4d-2008-5fb0-a9f82f89d10d@codesourcery.com> (raw)
Message-ID: <20220824175422.Fcd8wBD5k3EGSD62OrVrCSfelsJH71eTNhicOviYHBI@z> (raw)
In-Reply-To: <trinity-012e5ddc-6952-4399-ae35-4b6545e06ae3-1661286583461@3c-app-gmx-bap05>

[-- Attachment #1: Type: text/plain, Size: 2377 bytes --]

Dear Harald,

On 23.08.22 22:29, Harald Anlauf via Fortran wrote:

the simplification of the size of an array with a bad decl
should not be successful.  Improve the error recovery for
such a situation.

[...]

Regtested on x86_64-pc-linux-gnu.
The PR is marked as a 12/13 regression.  Will therefore
commit to both.


LGTM – and thanks for taking care of the Fortran bugs!

Tobias

[PATCH] Fortran: improve error recovery while simplifying size of bad array [PR103694]

gcc/fortran/ChangeLog:

        PR fortran/103694
        * simplify.cc (simplify_size): The size expression of an array cannot
        be simplified if an error occurs while resolving the array spec.

gcc/testsuite/ChangeLog:

        PR fortran/103694
        * gfortran.dg/pr103694.f90: New test.
---
 gcc/fortran/simplify.cc                |  5 +++--
 gcc/testsuite/gfortran.dg/pr103694.f90 | 11 +++++++++++
 2 files changed, 14 insertions(+), 2 deletions(-)
 create mode 100644 gcc/testsuite/gfortran.dg/pr103694.f90

diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc
index f992c31e5d7..bc178d54891 100644
--- a/gcc/fortran/simplify.cc
+++ b/gcc/fortran/simplify.cc
@@ -7536,8 +7536,9 @@ simplify_size (gfc_expr *array, gfc_expr *dim, int k)
     }

   for (ref = array->ref; ref; ref = ref->next)
-    if (ref->type == REF_ARRAY && ref->u.ar.as)
-      gfc_resolve_array_spec (ref->u.ar.as, 0);
+    if (ref->type == REF_ARRAY && ref->u.ar.as
+       && !gfc_resolve_array_spec (ref->u.ar.as, 0))
+      return NULL;

   if (dim == NULL)
     {
diff --git a/gcc/testsuite/gfortran.dg/pr103694.f90 b/gcc/testsuite/gfortran.dg/pr103694.f90
new file mode 100644
index 00000000000..3ed8b2088da
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr103694.f90
@@ -0,0 +1,11 @@
+! { dg-do compile }
+! PR fortran/103694 - ICE in gfc_conv_expr_op
+! Contributed by G.Steinmetz
+
+subroutine s
+  type t
+     integer :: a(2)
+  end type
+  type(t) :: x((0.)/0)
+  integer :: n = size(x(1)%a) ! { dg-error "does not reduce to a constant expression" }
+end


-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

  reply	other threads:[~2022-08-24 17:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 20:29 Harald Anlauf
2022-08-24 17:54 ` Tobias Burnus [this message]
2022-08-24 17:54   ` Tobias Burnus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df717057-9d4d-2008-5fb0-a9f82f89d10d@codesourcery.com \
    --to=tobias@codesourcery.com \
    --cc=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).