public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tobias Burnus <tobias@codesourcery.com>
To: Uros Bizjak <ubizjak@gmail.com>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	Fortran List <fortran@gcc.gnu.org>
Subject: Re: [PATCH] fortran: Rename TRUE/FALSE to true/false in *.cc files
Date: Fri, 25 Aug 2023 10:34:19 +0200	[thread overview]
Message-ID: <22cf226c-89d6-6931-2943-3bf988493904@codesourcery.com> (raw)
In-Reply-To: <CAFULd4ZNDHY-ihh-Vh72CohZ3izNgpg6L5raUogXONKTqS=2Sg@mail.gmail.com>

On 25.08.23 10:26, Uros Bizjak via Gcc-patches wrote:
> gcc/fortran/ChangeLog:
>
>      * match.cc (gfc_match_equivalence): Rename TRUE/FALSE to true/false.
>      * module.cc (check_access): Ditto.
>      * primary.cc (match_real_constant): Ditto.
>      * trans-array.cc (gfc_trans_allocate_array_storage): Ditto.
>      (get_array_ctor_strlen): Ditto.
>      * trans-common.cc (find_equivalence): Ditto.
>      (add_equivalences): Ditto.
>
> Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.
> OK for master?

OK. Not really necessary but it makes the code more consistent.

(We already heavily use true/false (5000+ times) and the patch changes
the remaining 11 TRUE/FALSE.)

Tobias

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

      reply	other threads:[~2023-08-25  8:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25  8:26 Uros Bizjak
2023-08-25  8:34 ` Tobias Burnus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22cf226c-89d6-6931-2943-3bf988493904@codesourcery.com \
    --to=tobias@codesourcery.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).