public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: fortran@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fortran: Fix handling of optional argument to SIZE intrinsic [PR103898]
Date: Thu, 6 Jan 2022 22:16:23 +0100	[thread overview]
Message-ID: <259f9768-cfaf-7a01-bc48-facf45f17767@gmx.de> (raw)
In-Reply-To: <e8d7da83-00ab-8fb0-eb87-915c52c4e85c@codesourcery.com>

Hi Sandra,

Am 06.01.22 um 21:11 schrieb Sandra Loosemore:
> This patch fixes an ICE introduced with the recent-ish rewrite to inline 
> the SIZE intrinsic, using a helper function to do the bulk of the work 
> in producing the expansion.  It turns out to be a simple think-o type 
> mistake in the wrapper around the helper rather than anything deeply 
> wrong with the logic.
> 
> OK to check in?

LGTM.

> -Sandra

Thanks for addressing this swiftly!


WARNING: multiple messages have this Message-ID

From: Harald Anlauf <anlauf@gmx.de>
To: Sandra Loosemore <sandra@codesourcery.com>,
	"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: Fix handling of optional argument to SIZE intrinsic [PR103898]
Date: Thu, 6 Jan 2022 22:16:23 +0100	[thread overview]
Message-ID: <259f9768-cfaf-7a01-bc48-facf45f17767@gmx.de> (raw)
Message-ID: <20220106211623.kHUuhNj0U7qDWVFwS9GsalOpNZneyOmxAsdQa5h7nkg@z> (raw)
In-Reply-To: <e8d7da83-00ab-8fb0-eb87-915c52c4e85c@codesourcery.com>

Hi Sandra,

Am 06.01.22 um 21:11 schrieb Sandra Loosemore:
> This patch fixes an ICE introduced with the recent-ish rewrite to inline
> the SIZE intrinsic, using a helper function to do the bulk of the work
> in producing the expansion.  It turns out to be a simple think-o type
> mistake in the wrapper around the helper rather than anything deeply
> wrong with the logic.
>
> OK to check in?

LGTM.

> -Sandra

Thanks for addressing this swiftly!

  reply	other threads:[~2022-01-06 21:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-06 20:11 Sandra Loosemore
2022-01-06 21:16 ` Harald Anlauf [this message]
2022-01-06 21:16   ` Harald Anlauf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=259f9768-cfaf-7a01-bc48-facf45f17767@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).