Re: [PATCH] Fortran: implement vector sections in DATA statements [PR49588]

[Harald Anlauf <anlauf@gmx.de>]

Hi Paul,

Am 22.08.23 um 08:32 schrieb Paul Richard Thomas via Gcc-patches:
> Hi Harald,
>
> It all looks good to me and does indeed make the code clearer. OK for trunk.
>
> Thanks for the patch.

thanks for the review!

> I was shocked to find that there are 217 older bugs than 49588. Does
> anybody test older bugs to check if any of them have been fixed?

I am not aware of this being done systematically.

At the same time, we have over 100 PRs marked as regression,
with a few being fixed on mainline but not backported (or
undecided whether to backport).  Fixing and/or closing them
might be low-hanging fruits.

There are also far more than 100 TODOs in gcc/fortran/*.cc ...

And with the usual PRs, there's enough work left for all kinds
of contributions.

Cheers,
Harald

> Paul
>
> On Mon, 21 Aug 2023 at 20:48, Harald Anlauf via Fortran
> <fortran@gcc.gnu.org> wrote:
>>
>> Dear all,
>>
>> the attached patch implements vector sections in DATA statements.
>>
>> The implementation is simpler than the size of the patch suggests,
>> as part of changes try to clean up the existing code to make it
>> easier to understand, as ordinary sections (start:end:stride)
>> and vector sections may actually share some common code.
>>
>> The basisc idea of the implementation is that one needs a
>> temporary vector that keeps track of the offsets into the
>> array constructors for the indices in the array reference
>> that are vectors.
>>
>> Regtested on x86_64-pc-linux-gnu.  OK for mainline?
>>
>> Thanks,
>> Harald
>>
>