From: Mikael Morin <morin-mikael@orange.fr>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gfortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [pushed] testsuite: add additional option to force DSE execution [PR103662]
Date: Mon, 25 Apr 2022 15:29:22 +0200 [thread overview]
Message-ID: <3a25a2f6-cc9e-0b9b-7837-b3f01df19b95@orange.fr> (raw)
In-Reply-To: <YmaQLjqBgiH4yCqs@tucnak>
Le 25/04/2022 à 14:12, Jakub Jelinek a écrit :
> On Mon, Apr 25, 2022 at 01:38:25PM +0200, Mikael Morin wrote:
>> I have just pushed the attached fix for two UNRESOLVED checks at -O0 that I
>> hadn’t seen.
>
> I don't like forcing of DSE in -O0 compilation, wouldn't it be better
> to just not check the dse dump at -O0 like in the following patch?
>
Certainly better. I actually looked for something alike already
existing before trying to write a conditional in the dg-final code and
finally deciding to go the easy way.
> Even better would be to check that the z._data = stores are both present
> in *.optimized dump, but that doesn't really work at -O2 or above because
> we inline the functions and optimize it completely away (both the stores
> and corresponding reads).
>
Yes, and global optimization is already checked by test execution anyway.
> The first hunk is needed so that __OPTIMIZE__ effective target works in
> Fortran testsuite, otherwise one gets a pedantic error and __OPTIMIZE__
> is considered not to match at all.
>
Maybe worth putting as code comment.
OK from my side, thanks.
next prev parent reply other threads:[~2022-04-25 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 21:14 [PATCH] fortran: Detect duplicate unlimited polymorphic types [PR103662] Mikael Morin
2022-04-22 10:53 ` [PATCH v2] " Mikael Morin
2022-04-23 20:27 ` Harald Anlauf
2022-04-25 11:38 ` [pushed] testsuite: add additional option to force DSE execution [PR103662] Mikael Morin
2022-04-25 12:12 ` Jakub Jelinek
2022-04-25 13:29 ` Mikael Morin [this message]
2022-04-25 20:35 ` Bernhard Reutner-Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a25a2f6-cc9e-0b9b-7837-b3f01df19b95@orange.fr \
--to=morin-mikael@orange.fr \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).