Re: [PATCH] fortran: gfc_trans_subcomponent_assign fixes [PR113503]

[Harald Anlauf <anlauf@gmx.de>]

Hi Jakub,

On 2/17/24 10:02, Jakub Jelinek wrote:
> Hi!
>
> The r14-870 changes broke xtb package tests (reduced testcase is the first
> one below) and caused ICEs on a test derived from that (the second one).
[...]

thanks for your detailed analysis and for the patch, which puts
things in straight order to actually fix two issues here!

> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?

OK for trunk, except for the minor nit below.

> --- gcc/testsuite/gfortran.dg/pr113503_1.f90.jj	2024-02-16 14:16:17.937153094 +0100
> +++ gcc/testsuite/gfortran.dg/pr113503_1.f90	2024-02-16 14:16:10.124258815 +0100
> @@ -0,0 +1,18 @@
> +! PR fortran/113503
> +! { dg-do compile }
> +! { dg-options "-O2 -fno-inline -Wuninitialized" }
> +
> +program pr113503
> +  implicit none
> +  type :: T
> +    character(len=:), allocatable :: u
> +  end type
> +  character(len=20) :: us(1) = 'foobar'
> +  type(T) :: x
> +  x = T(u = trim (us(1)))	! { dg-bogus "is used uninitialized" }
                             ^^^^ tab here not allowed in Fortran

My newsreader shows a tab here, giving a warning when running the test.
Also, applying your patch on top of r14-9045 I do not see the
uninitialized warning, which could have been fixed by r14-8947.
Please recheck and adjust accordingly.

> +  call foo
> +contains
> +  subroutine foo
> +    if (x%u /= 'foobar') stop 1
> +  end subroutine
> +end

Thanks,
Harald