public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: Tobias Burnus <tobias@codesourcery.com>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
	fortran <fortran@gcc.gnu.org>
Subject: Re: [patch] fortran/intrinsic.texi: Add 'passed by value' to signal handler
Date: Mon, 16 Oct 2023 20:31:20 +0200	[thread overview]
Message-ID: <3f2d2471-dd94-4eb1-86b2-ae7ed439028b@gmx.de> (raw)
In-Reply-To: <a663b83c-356a-410c-871b-1897d12fd76a@codesourcery.com>

Hi Tobias,

Am 16.10.23 um 19:11 schrieb Tobias Burnus:
> Yesterday, someone was confused because the signal handler did not work.
>
> It turned out that the created Fortran procedure used as handler used
> pass by reference - and 'signal' passed the it by value.
>
> This patch adds the 'passed by value' to the wording:
>
> "@var{HANDLER} to be executed with a single integer argument passed by
> value"
>
> OK for mainline?

I think the patch qualifies as obvious.

While at it, you might consider removing the comment a few lines below
the place you are changing,

@c TODO: What should the interface of the handler be?  Does it take
arguments?

and enhance the given example by e.g.:

subroutine handler_print (signal_number)
   integer, value :: signal_number
   print *, "In handler_print: received signal number", signal_number
end subroutine handler_print

Thanks,
Harald

> Tobias
> -----------------
> Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201,
> 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer:
> Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München;
> Registergericht München, HRB 106955


  reply	other threads:[~2023-10-16 18:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16 17:11 Tobias Burnus
2023-10-16 18:31 ` Harald Anlauf [this message]
2023-10-16 18:37   ` Steve Kargl
2023-10-17  7:47   ` [patch] fortran/intrinsic.texi: Improve SIGNAL intrinsic entry (was: [patch] fortran/intrinsic.texi: Add 'passed by value' to signal handler) Tobias Burnus
2023-10-17 17:02     ` [patch] fortran/intrinsic.texi: Improve SIGNAL intrinsic entry Harald Anlauf
2023-10-17 17:36       ` Tobias Burnus
2023-10-17 18:05         ` Harald Anlauf
2023-10-17 11:26 ` [patch] fortran/intrinsic.texi: Add 'passed by value' to signal handler Stanislav Maslovski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f2d2471-dd94-4eb1-86b2-ae7ed439028b@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=tobias@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).