Re: [patch] fortran/intrinsic.texi: Improve SIGNAL intrinsic entry

[Harald Anlauf <anlauf@gmx.de>]

Tobias,

your latest patch - which you already pushed - removes the
intrinsic declaration of signal.

This can lead to a user's confusion and undesired results when
the code is compiled e.g. with -std=f2018, because

   call signal (10, 1)  ! 10 = SIGUSR1 and 1 = SIG_IGN (on some systems)

could be mapped to the wrong external instead of the
libgfortran function _gfortran_signal_sub_int etc., or you
could get other compile-time errors with the example code.

I strongly recommend to restore the intrinsic declaration.

Cheers,
Harald

Am 17.10.23 um 09:47 schrieb Tobias Burnus:
> Hi Harald,
>
> On 16.10.23 20:31, Harald Anlauf wrote:
>> Hi Tobias,
>>
>> Am 16.10.23 um 19:11 schrieb Tobias Burnus:
>>> OK for mainline?
>>
>> I think the patch qualifies as obvious.
>>
>> While at it, you might consider removing the comment a few lines below
>> the place you are changing,
>>
>> @c TODO: What should the interface of the handler be?  Does it take
>> arguments?
>>
>> and enhance the given example by e.g.:
>
> Updated version attached – I will commit it later today, unless anyone
> has follow-up suggestions before.
>
> Thanks for the suggestions,
>
> Tobias
> -----------------
> Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201,
> 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer:
> Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München;
> Registergericht München, HRB 106955