public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: Mikael Morin <morin-mikael@orange.fr>,
	gfortran <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] fortran: Separate associate character lengths earlier [PR104570]
Date: Wed, 16 Mar 2022 22:24:11 +0100	[thread overview]
Message-ID: <4124db5c-55f0-0bb9-b352-2bdccba95f74@gmx.de> (raw)
In-Reply-To: <4cce238d-5fdc-4a94-908b-9a1399193493@orange.fr>

Hi Mikael,

Am 14.03.22 um 19:28 schrieb Mikael Morin:
> Hello,
>
> this workarounds the regression I introduced with the fix for pr104228.
> The problem comes from the evaluation of character length for the
> associate target (y) in the testcase.
> The expression is non-scalar which is not supported at that point, as no
> scalarization setup is made there.
>
> My initial direction to fix this was trying to modify the evaluation of
> expressions so that the rank was ignored in the context of character
> length evaluation.
> That’s the patch I attached to the PR.
> The patch I’m proposing here tries instead to avoid the need to evaluate
> character length through sharing of gfc_charlen between symbols and
> expressions.
> I slightly prefer the latter direction, though I’m not sure it’s more
> robust. > At least it passes regression testing, which proves some basic level of
> goodness.
> OK for master?

I tried a few minor variations of the testcase, and they
also seemed to work.  The patch looks simple enough, so
OK from my side.

> Even if PR104570 is a 12 regression only, the PR104228 fix is targeted
> at all the open branches so this one as well.
> OK for 11/10/9?

Yes, after giving it a short time on master to "burn in".

Thanks for the patch!

Harald

WARNING: multiple messages have this Message-ID

From: Harald Anlauf <anlauf@gmx.de>
To: fortran@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] fortran: Separate associate character lengths earlier [PR104570]
Date: Wed, 16 Mar 2022 22:24:11 +0100	[thread overview]
Message-ID: <4124db5c-55f0-0bb9-b352-2bdccba95f74@gmx.de> (raw)
Message-ID: <20220316212411.sRn8WYMLjuPRyMnffrXRZ4PCRZNuBDQXPkvW0jwxdgQ@z> (raw)
In-Reply-To: <4cce238d-5fdc-4a94-908b-9a1399193493@orange.fr>

Hi Mikael,

Am 14.03.22 um 19:28 schrieb Mikael Morin:
> Hello,
> 
> this workarounds the regression I introduced with the fix for pr104228.
> The problem comes from the evaluation of character length for the 
> associate target (y) in the testcase.
> The expression is non-scalar which is not supported at that point, as no 
> scalarization setup is made there.
> 
> My initial direction to fix this was trying to modify the evaluation of 
> expressions so that the rank was ignored in the context of character 
> length evaluation.
> That’s the patch I attached to the PR.
> The patch I’m proposing here tries instead to avoid the need to evaluate 
> character length through sharing of gfc_charlen between symbols and 
> expressions.
> I slightly prefer the latter direction, though I’m not sure it’s more 
> robust. > At least it passes regression testing, which proves some basic level of
> goodness.
> OK for master?

I tried a few minor variations of the testcase, and they
also seemed to work.  The patch looks simple enough, so
OK from my side.

> Even if PR104570 is a 12 regression only, the PR104228 fix is targeted 
> at all the open branches so this one as well.
> OK for 11/10/9?

Yes, after giving it a short time on master to "burn in".

Thanks for the patch!

Harald


  reply	other threads:[~2022-03-16 21:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14 18:28 Mikael Morin
2022-03-16 21:24 ` Harald Anlauf [this message]
2022-03-16 21:24   ` Harald Anlauf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4124db5c-55f0-0bb9-b352-2bdccba95f74@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=morin-mikael@orange.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).