From: Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>
To: Ben Boeckel <ben.boeckel@kitware.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Jason Merrill <jason@redhat.com>,
nathan@acm.org, fortran@gcc.gnu.org, gcc@gcc.gnu.org,
brad.king@kitware.com
Subject: Re: [PATCH v6 0/4] P1689R5 support
Date: Thu, 8 Jun 2023 21:59:13 +0400 [thread overview]
Message-ID: <444B887D-CA74-47EF-AD02-F17D000FE9A4@linaro.org> (raw)
In-Reply-To: <20230606205025.3164738-1-ben.boeckel@kitware.com>
> On Jun 7, 2023, at 00:50, Ben Boeckel via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
>
> Hi,
>
> This patch series adds initial support for ISO C++'s [P1689R5][], a
> format for describing C++ module requirements and provisions based on
> the source code. This is required because compiling C++ with modules is
> not embarrassingly parallel and need to be ordered to ensure that
> `import some_module;` can be satisfied in time by making sure that any
> TU with `export import some_module;` is compiled first.
Hi Ben,
This patch series causes ICEs on arm-linux-gnueabihf. Would you please investigate? Please let me know if you need any in reproducing these.
=== g++ tests ===
Running g++:g++.dg/modules/modules.exp ...
FAIL: g++.dg/modules/ben-1_a.C -std=c++17 (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/ben-1_a.C -std=c++17 (test for excess errors)
FAIL: g++.dg/modules/ben-1_a.C -std=c++2a (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/ben-1_a.C -std=c++2a (test for excess errors)
FAIL: g++.dg/modules/ben-1_a.C -std=c++2b (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/ben-1_a.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/ben-1_a.C module-cmi =partitions/module-import.mod (partitions/module-import.mod)
FAIL: g++.dg/modules/ben-1_b.C -std=c++17 (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/ben-1_b.C -std=c++17 (test for excess errors)
FAIL: g++.dg/modules/ben-1_b.C -std=c++2a (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/ben-1_b.C -std=c++2a (test for excess errors)
FAIL: g++.dg/modules/ben-1_b.C -std=c++2b (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/ben-1_b.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/ben-1_b.C module-cmi =module.mod (module.mod)
FAIL: g++.dg/modules/gc-2_a.C -std=c++17 (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/gc-2_a.C -std=c++17 (test for excess errors)
FAIL: g++.dg/modules/gc-2_a.C -std=c++2a (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/gc-2_a.C -std=c++2a (test for excess errors)
FAIL: g++.dg/modules/gc-2_a.C -std=c++2b (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/gc-2_a.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/gc-2_a.C module-cmi =map-1_a.nms (map-1_a.nms)
UNRESOLVED: g++.dg/modules/map-1 -std=c++17 execute
UNRESOLVED: g++.dg/modules/map-1 -std=c++17 link
UNRESOLVED: g++.dg/modules/map-1 -std=c++2a execute
UNRESOLVED: g++.dg/modules/map-1 -std=c++2a link
UNRESOLVED: g++.dg/modules/map-1 -std=c++2b execute
UNRESOLVED: g++.dg/modules/map-1 -std=c++2b link
FAIL: g++.dg/modules/map-1_a.C -std=c++17 (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/map-1_a.C -std=c++17 (test for excess errors)
FAIL: g++.dg/modules/map-1_a.C -std=c++2a (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/map-1_a.C -std=c++2a (test for excess errors)
FAIL: g++.dg/modules/map-1_a.C -std=c++2b (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/map-1_a.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/map-1_a.C module-cmi =map-1_a.nms (map-1_a.nms)
FAIL: g++.dg/modules/map-1_b.C -std=c++17 (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/map-1_b.C -std=c++17 (test for excess errors)
FAIL: g++.dg/modules/map-1_b.C -std=c++2a (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/map-1_b.C -std=c++2a (test for excess errors)
FAIL: g++.dg/modules/map-1_b.C -std=c++2b (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/map-1_b.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/map-2.C -std=c++17 at line 8 (test for errors, line 7)
FAIL: g++.dg/modules/map-2.C -std=c++17 at line 9 (test for errors, line )
FAIL: g++.dg/modules/map-2.C -std=c++17 (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/map-2.C -std=c++17 (test for excess errors)
FAIL: g++.dg/modules/map-2.C -std=c++2a at line 8 (test for errors, line 7)
FAIL: g++.dg/modules/map-2.C -std=c++2a at line 9 (test for errors, line )
FAIL: g++.dg/modules/map-2.C -std=c++2a (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/map-2.C -std=c++2a (test for excess errors)
FAIL: g++.dg/modules/map-2.C -std=c++2b at line 8 (test for errors, line 7)
FAIL: g++.dg/modules/map-2.C -std=c++2b at line 9 (test for errors, line )
FAIL: g++.dg/modules/map-2.C -std=c++2b (internal compiler error: Segmentation fault)
FAIL: g++.dg/modules/map-2.C -std=c++2b (test for excess errors)
===
Thanks,
--
Maxim Kuvyrkov
https://www.linaro.org
>
> [P1689R5]: https://isocpp.org/files/papers/P1689R5.html
>
> I've also added patches to include imported module CMI files and the
> module mapper file as dependencies of the compilation. I briefly looked
> into adding dependencies on response files as well, but that appeared to
> need some code contortions to have a `class mkdeps` available before
> parsing the command line or to keep the information around until one was
> made.
>
> I'd like feedback on the approach taken here with respect to the
> user-visible flags. I'll also note that header units are not supported
> at this time because the current `-E` behavior with respect to `import
> <some_header>;` is to search for an appropriate `.gcm` file which is not
> something such a "scan" can support. A new mode will likely need to be
> created (e.g., replacing `-E` with `-fc++-module-scanning` or something)
> where headers are looked up "normally" and processed only as much as
> scanning requires.
>
> FWIW, Clang as taken an alternate approach with its `clang-scan-deps`
> tool rather than using the compiler directly.
>
> Thanks,
>
> --Ben
>
> ---
> v5 -> v6:
>
> - rebase onto `master` (585c660f041 (reload1: Change return type of
> predicate function from int to bool, 2023-06-06))
> - fix crash related to reporting imported CMI files as dependencies
> - rework utf-8 validity to patch the new `cpp_valid_utf8_p` function
> instead of the core utf-8 decoding routine to reject invalid
> codepoints (preserves higher-level error detection of invalid utf-8)
> - harmonize of `fdeps` spelling in flags, variables, comments, etc.
> - rename `-fdeps-output=` to `-fdeps-target=`
>
> v4 -> v5:
>
> - add dependency tracking for imported modules to `-MF`
> - add dependency tracking for static module mapper files given to
> `-fmodule-mapper=`
>
> v3 -> v4:
>
> - add missing spaces between function names and arguments
>
> v2 -> v3:
>
> - changelog entries moved to commit messages
> - documentation updated/added in the UTF-8 routine editing
>
> v1 -> v2:
>
> - removal of the `deps_write(extra)` parameter to option-checking where
> ndeeded
> - default parameter of `cpp_finish(fdeps_stream = NULL)`
> - unification of libcpp UTF-8 validity functions from v1
> - test cases for flag parsing states (depflags-*) and p1689 output
> (p1689-*)
>
> Ben Boeckel (4):
> libcpp: reject codepoints above 0x10FFFF
> p1689r5: initial support
> c++modules: report imported CMI files as dependencies
> c++modules: report module mapper files as a dependency
>
> gcc/c-family/c-opts.cc | 40 +++-
> gcc/c-family/c.opt | 12 +
> gcc/cp/mapper-client.cc | 4 +
> gcc/cp/mapper-client.h | 1 +
> gcc/cp/module.cc | 24 +-
> gcc/doc/invoke.texi | 15 ++
> gcc/testsuite/g++.dg/modules/depflags-f-MD.C | 2 +
> gcc/testsuite/g++.dg/modules/depflags-f.C | 1 +
> gcc/testsuite/g++.dg/modules/depflags-fi.C | 3 +
> gcc/testsuite/g++.dg/modules/depflags-fj-MD.C | 3 +
> gcc/testsuite/g++.dg/modules/depflags-fj.C | 4 +
> .../g++.dg/modules/depflags-fjo-MD.C | 4 +
> gcc/testsuite/g++.dg/modules/depflags-fjo.C | 5 +
> gcc/testsuite/g++.dg/modules/depflags-fo-MD.C | 3 +
> gcc/testsuite/g++.dg/modules/depflags-fo.C | 4 +
> gcc/testsuite/g++.dg/modules/depflags-j-MD.C | 2 +
> gcc/testsuite/g++.dg/modules/depflags-j.C | 3 +
> gcc/testsuite/g++.dg/modules/depflags-jo-MD.C | 3 +
> gcc/testsuite/g++.dg/modules/depflags-jo.C | 4 +
> gcc/testsuite/g++.dg/modules/depflags-o-MD.C | 2 +
> gcc/testsuite/g++.dg/modules/depflags-o.C | 3 +
> gcc/testsuite/g++.dg/modules/modules.exp | 1 +
> gcc/testsuite/g++.dg/modules/p1689-1.C | 18 ++
> gcc/testsuite/g++.dg/modules/p1689-1.exp.json | 27 +++
> gcc/testsuite/g++.dg/modules/p1689-2.C | 16 ++
> gcc/testsuite/g++.dg/modules/p1689-2.exp.json | 16 ++
> gcc/testsuite/g++.dg/modules/p1689-3.C | 14 ++
> gcc/testsuite/g++.dg/modules/p1689-3.exp.json | 16 ++
> gcc/testsuite/g++.dg/modules/p1689-4.C | 14 ++
> gcc/testsuite/g++.dg/modules/p1689-4.exp.json | 14 ++
> gcc/testsuite/g++.dg/modules/p1689-5.C | 14 ++
> gcc/testsuite/g++.dg/modules/p1689-5.exp.json | 14 ++
> gcc/testsuite/g++.dg/modules/test-p1689.py | 222 ++++++++++++++++++
> gcc/testsuite/lib/modules.exp | 71 ++++++
> libcpp/charset.cc | 7 +
> libcpp/include/cpplib.h | 12 +-
> libcpp/include/mkdeps.h | 17 +-
> libcpp/init.cc | 13 +-
> libcpp/mkdeps.cc | 149 +++++++++++-
> 39 files changed, 769 insertions(+), 28 deletions(-)
> create mode 100644 gcc/testsuite/g++.dg/modules/depflags-f-MD.C
> create mode 100644 gcc/testsuite/g++.dg/modules/depflags-f.C
> create mode 100644 gcc/testsuite/g++.dg/modules/depflags-fi.C
> create mode 100644 gcc/testsuite/g++.dg/modules/depflags-fj-MD.C
> create mode 100644 gcc/testsuite/g++.dg/modules/depflags-fj.C
> create mode 100644 gcc/testsuite/g++.dg/modules/depflags-fjo-MD.C
> create mode 100644 gcc/testsuite/g++.dg/modules/depflags-fjo.C
> create mode 100644 gcc/testsuite/g++.dg/modules/depflags-fo-MD.C
> create mode 100644 gcc/testsuite/g++.dg/modules/depflags-fo.C
> create mode 100644 gcc/testsuite/g++.dg/modules/depflags-j-MD.C
> create mode 100644 gcc/testsuite/g++.dg/modules/depflags-j.C
> create mode 100644 gcc/testsuite/g++.dg/modules/depflags-jo-MD.C
> create mode 100644 gcc/testsuite/g++.dg/modules/depflags-jo.C
> create mode 100644 gcc/testsuite/g++.dg/modules/depflags-o-MD.C
> create mode 100644 gcc/testsuite/g++.dg/modules/depflags-o.C
> create mode 100644 gcc/testsuite/g++.dg/modules/p1689-1.C
> create mode 100644 gcc/testsuite/g++.dg/modules/p1689-1.exp.json
> create mode 100644 gcc/testsuite/g++.dg/modules/p1689-2.C
> create mode 100644 gcc/testsuite/g++.dg/modules/p1689-2.exp.json
> create mode 100644 gcc/testsuite/g++.dg/modules/p1689-3.C
> create mode 100644 gcc/testsuite/g++.dg/modules/p1689-3.exp.json
> create mode 100644 gcc/testsuite/g++.dg/modules/p1689-4.C
> create mode 100644 gcc/testsuite/g++.dg/modules/p1689-4.exp.json
> create mode 100644 gcc/testsuite/g++.dg/modules/p1689-5.C
> create mode 100644 gcc/testsuite/g++.dg/modules/p1689-5.exp.json
> create mode 100644 gcc/testsuite/g++.dg/modules/test-p1689.py
> create mode 100644 gcc/testsuite/lib/modules.exp
>
>
> base-commit: 585c660f041c57694a61b3e65085af5a54431be4
> --
> 2.40.1
>
next prev parent reply other threads:[~2023-06-08 17:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 20:50 Ben Boeckel
2023-06-06 20:50 ` [PATCH v6 1/4] libcpp: reject codepoints above 0x10FFFF Ben Boeckel
2023-06-19 21:34 ` Jason Merrill
2023-06-06 20:50 ` [PATCH v6 2/4] p1689r5: initial support Ben Boeckel
2023-06-06 20:50 ` [PATCH v6 3/4] c++modules: report imported CMI files as dependencies Ben Boeckel
2023-06-06 20:50 ` [PATCH v6 4/4] c++modules: report module mapper files as a dependency Ben Boeckel
2023-06-08 17:59 ` Maxim Kuvyrkov [this message]
2023-06-16 19:48 ` [PATCH v6 0/4] P1689R5 support Ben Boeckel
2023-06-16 23:15 ` Ben Boeckel
2023-06-17 3:55 ` Jason Merrill
2023-06-17 14:43 ` Ben Boeckel
2023-06-20 0:54 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=444B887D-CA74-47EF-AD02-F17D000FE9A4@linaro.org \
--to=maxim.kuvyrkov@linaro.org \
--cc=ben.boeckel@kitware.com \
--cc=brad.king@kitware.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).