Re: [PATCH v6 0/4] P1689R5 support

[Ben Boeckel <ben.boeckel@kitware.com>]

On Fri, Jun 16, 2023 at 23:55:53 -0400, Jason Merrill wrote:
> I see the same thing with patch 4 on x86_64-pc-linux-gnu, e.g.
> 
> FAIL: g++.dg/modules/ben-1_a.C -std=c++17 (test for excess errors)
> Excess errors:
> /home/jason/gt/gcc/testsuite/g++.dg/modules/ben-1_a.C:9:1: internal
> compiler error: Segmentation fault
> 0x19e2f3c crash_signal
>         /home/jason/gt/gcc/toplev.cc:314
> 0x340f3f8 mkdeps::vec<mkdeps::velt>::size() const
>         /home/jason/gt/libcpp/mkdeps.cc:57
> 0x340dc1f apply_vpath
>         /home/jason/gt/libcpp/mkdeps.cc:194
> 0x340e08e deps_add_dep(mkdeps*, char const*)
>         /home/jason/gt/libcpp/mkdeps.cc:318
> 0xea7b51 module_client::open_module_client(unsigned int, char const*,
> mkdeps*, void (*)(char const*), char const*)
>         /home/jason/gt/gcc/cp/mapper-client.cc:291
> 0xef2ba8 make_mapper
>         /home/jason/gt/gcc/cp/module.cc:14042
> 0xf0896c get_mapper(unsigned int, mkdeps*)
>         /home/jason/gt/gcc/cp/module.cc:3977
> 0xf032ac name_pending_imports
>         /home/jason/gt/gcc/cp/module.cc:19623
> 0xf03a7d preprocessed_module(cpp_reader*)
>         /home/jason/gt/gcc/cp/module.cc:19817
> 0xe85104 module_token_cdtor(cpp_reader*, unsigned long)
>         /home/jason/gt/gcc/cp/lex.cc:548
> 0xf467b2 cp_lexer_new_main
>         /home/jason/gt/gcc/cp/parser.cc:756
> 0xfc1e3a c_parse_file()
>         /home/jason/gt/gcc/cp/parser.cc:49725
> 0x11c5bf5 c_common_parse_file()
>         /home/jason/gt/gcc/c-family/c-opts.cc:1268

Thanks. I missed a `nullptr` check before calling `deps_add_dep`. I
think I got misled by `make check` returning a zero exit code even if
there are failures.

Thanks,

--Ben