From: Thomas Koenig <tkoenig@netcologne.de>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>,
Xi Ruoyao <xry111@xry111.site>
Cc: gcc-patches@gcc.gnu.org,
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
Arnaud Charlet <charlet@adacore.com>,
Jonathan Wakely <jwakely@redhat.com>,
fortran@gcc.gnu.org
Subject: Re: [PATCH v2 4/7] fortran: use grep instead of fgrep
Date: Wed, 10 May 2023 22:02:14 +0200 [thread overview]
Message-ID: <48620eb1-699b-5d34-2c72-356f8f059b04@netcologne.de> (raw)
In-Reply-To: <20230510212925.23e2837b@nbbrfq>
On 10.05.23 21:29, Bernhard Reutner-Fischer via Fortran wrote:
> On Mon, 27 Jun 2022 14:10:36 +0800
> Xi Ruoyao <xry111@xry111.site> wrote:
>
>> fgrep has been deprecated in favor of grep -F for a long time, and the
>> next grep release (3.8 or 4.0) will print a warning of fgrep is used.
>> Stop using fgrep so we won't see the warning.
>>
>> We can't hard code grep -F here or it may break build on hosts w/o GNU
>> grep. autoconf documentation contains a warning about this issue and
>> suggest to use AC_PROG_FGREP and $FGREP, but these are too overkill in
>> the specific case: there is no way "debian" could be interpreted as an
>> non-trivial regex, so we can use a plain grep here.
>
> LGTM but i cannot approve it. I'd say this one is trivial and obvious
> so you could sneak it in under the "obvious" rule..
I concur, this could also have been obvious.
Anyway, OK for trunk, and
> Thanks for the patch!
next prev parent reply other threads:[~2023-05-10 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fb82297845486b14d51905ae3df8dbba726fcf57.camel@xry111.site>
2022-06-27 6:10 ` Xi Ruoyao
2023-05-10 19:29 ` Bernhard Reutner-Fischer
2023-05-10 20:02 ` Thomas Koenig [this message]
2023-05-11 9:01 ` Pushed: " Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48620eb1-699b-5d34-2c72-356f8f059b04@netcologne.de \
--to=tkoenig@netcologne.de \
--cc=charlet@adacore.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=rep.dot.nop@gmail.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).