From: Mikael Morin <morin-mikael@orange.fr>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>,
gcc-patches@gcc.gnu.org, Jan Hubicka <hubicka@ucw.cz>
Cc: Bernhard Reutner-Fischer <aldot@gcc.gnu.org>,
gfortran ML <fortran@gcc.gnu.org>
Subject: Re: [PATCH 1/2] symtab: also change RTL decl name
Date: Mon, 21 Nov 2022 19:24:24 +0100 [thread overview]
Message-ID: <4ac33f88-c3bf-91d2-aa8d-be936676b679@orange.fr> (raw)
In-Reply-To: <20221117090219.2884af08@nbbrfq>
Hello,
Le 17/11/2022 à 09:02, Bernhard Reutner-Fischer via Fortran a écrit :
> Hi Honza, Ping.
> Regtests cleanly for c,fortran,c++,ada,d,go,lto,objc,obj-c++
> Ok?
> I'd need this for attribute target_clones for the Fortran FE.
> thanks,
>
> On Wed, 9 Nov 2022 20:02:24 +0100
> Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote:
>
>> We were changing the ASSEMBLER_NAME of the function decl
>> but not the name in DECL_RTL which is used as the function name
>> fnname in rest_of_handle_final(). This led to using the old, wrong name
>> for the attribute target default function when using target_clones.
>>
>> Bootstrapped and regtested cleanly on x86_64-unknown-linux
>> for c,c++,fortran,lto.
>> Ok for trunk?
>>
>> gcc/ChangeLog:
>>
>> * symtab.cc: Remove stray comment.
>> (symbol_table::change_decl_assembler_name): Also update the
>> name in DECL_RTL.
>>
(patch stripped)
Is there a PR about this? Or a testcase exhibiting the problem at least?
next prev parent reply other threads:[~2022-11-21 18:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 19:02 [PATCH 0/2] Fortran: add attribute target_clones Bernhard Reutner-Fischer
2022-11-09 19:02 ` [PATCH 1/2] symtab: also change RTL decl name Bernhard Reutner-Fischer
2022-11-17 8:02 ` Bernhard Reutner-Fischer
2022-11-21 18:24 ` Mikael Morin [this message]
2022-11-21 19:02 ` Jan Hubicka
2022-11-21 19:47 ` Bernhard Reutner-Fischer
2022-11-22 11:54 ` Jan Hubicka
2023-02-19 2:29 ` Bernhard Reutner-Fischer
2023-02-19 2:49 ` Bernhard Reutner-Fischer
2022-11-09 19:02 ` [PATCH 2/2] Fortran: add attribute target_clones Bernhard Reutner-Fischer
2022-11-21 19:13 ` Mikael Morin
2022-11-21 22:26 ` Bernhard Reutner-Fischer
2022-11-22 13:17 ` Mikael Morin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ac33f88-c3bf-91d2-aa8d-be936676b679@orange.fr \
--to=morin-mikael@orange.fr \
--cc=aldot@gcc.gnu.org \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=rep.dot.nop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).