From: Harald Anlauf <anlauf@gmx.de>
To: Mikael Morin <morin-mikael@orange.fr>,
gfortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] fortran: Unshare associate var charlen [PR104228]
Date: Wed, 2 Feb 2022 21:20:32 +0100 [thread overview]
Message-ID: <67713536-50cf-575e-9fdb-20d83a095d0b@gmx.de> (raw)
In-Reply-To: <204cec48-ce99-500a-7951-939ee51d31d6@orange.fr>
Hi Mikael,
Am 29.01.22 um 15:24 schrieb Mikael Morin:
> Hello,
>
> the attached patch is a fix for PR104228.
> Even if simple, I wouldn’t call it obvious, as it’s involving character
> length and associate, so I don’t mind some extra review eyes.
I am probably not experienced enough to review this. Paul?
Nevertheless, I looked at the commits that introduced the code
you touched. It appears that these did not cover, maybe even
avoid the current case where the associate target is not a dummy.
Your changes seem to make sense and fix the issue.
> Tested on x86_64-pc-linux-gnu. Ok for master/11/10/9?
OK, and thanks for the patch!
Harald
next prev parent reply other threads:[~2022-02-02 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 14:24 Mikael Morin
2022-02-02 20:20 ` Harald Anlauf [this message]
2022-02-03 17:49 ` Paul Richard Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67713536-50cf-575e-9fdb-20d83a095d0b@gmx.de \
--to=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=morin-mikael@orange.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).