From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: LIU Hao <lh_mouse@126.com>,
LIU Hao via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: fortran@gcc.gnu.org
Subject: Re: Adding a new thread model to GCC
Date: Tue, 04 Oct 2022 21:45:00 +0200 [thread overview]
Message-ID: <8720EB01-D0D0-41A4-A78D-54A39C8F13E4@gmail.com> (raw)
In-Reply-To: <18773926-d861-0351-30e9-e7e1b832fc61@126.com>
On 4 October 2022 10:06:00 CEST, LIU Hao <lh_mouse@126.com> wrote:
>在 2022-10-03 13:03, Bernhard Reutner-Fischer 写道:
>>
>> No, sorry for my brevity.
>> Using __gthread_t like in your patch is correct.
>>
>
>I see. In 'libgfortran/io/async.c' there is
>
> ```
> async_unit *au = u->au;
> LOCK (&au->lock);
> thread_unit = u;
> au->thread = __gthread_self ();
> ```
>
>so indeed `thread` should be `__gthread_t`.
Yes.
> By the way I reported this issue four months ago and haven't received any response so far:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105764
So, ideally, you would mention this PR in your patch.
LGTM (obvious even) but I cannot formally approve it.
thanks,
next prev parent reply other threads:[~2022-10-04 19:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0f1f223a-3756-1da3-bd1d-b87edd34e1f9@126.com>
2022-10-01 20:02 ` Bernhard Reutner-Fischer
2022-10-02 12:54 ` LIU Hao
2022-10-03 5:03 ` Bernhard Reutner-Fischer
2022-10-04 8:06 ` LIU Hao
2022-10-04 19:45 ` Bernhard Reutner-Fischer [this message]
[not found] ` <21655510.EfDdHjke4D@fomalhaut>
[not found] ` <CACb0b4nhp89FmAHkuYEZs=nsL4Ge3oEV3G_gZ28FkDuud+Zxpg@mail.gmail.com>
[not found] ` <2092961.OBFZWjSADL@fomalhaut>
[not found] ` <45c84c01-74ca-3739-6482-2bbc94de0e9a@gmail.com>
[not found] ` <00af136c637f5231670c0fb6f7906d42@autistici.org>
[not found] ` <f454d3d7-3e70-6eb3-44d6-8213b6888a37@gmail.com>
2022-12-24 5:58 ` NightStrike
2022-12-24 6:27 ` i.nixman
2022-12-24 13:50 ` i.nixman
2022-12-24 15:42 ` i.nixman
2022-12-24 15:57 ` i.nixman
2022-12-24 21:22 ` i.nixman
2022-12-25 1:10 ` Jonathan Yong
2023-01-09 21:56 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8720EB01-D0D0-41A4-A78D-54A39C8F13E4@gmail.com \
--to=rep.dot.nop@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=lh_mouse@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).